-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix/issue 4578 path normalization for unix and windows #4614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Rusted2361
wants to merge
10
commits into
trufflesecurity:main
Choose a base branch
from
Rusted2361:fix/issue-4578-incorrect-paths-on-windows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4eb274b
Fix Windows file:// URI normalization and index path handling
Rusted2361 0fea52f
add condition to trim leading slash only incase of windows paths
Rusted2361 7360028
Merge branch 'main' into fix/issue-4578-incorrect-paths-on-windows
Rusted2361 73ab733
access path from URL object and identify platform using goos
Rusted2361 2f78c8a
Merge branch 'main' into fix/issue-4578-incorrect-paths-on-windows
kashifkhan0771 c9565d1
simplified path logic
Rusted2361 5b37bbc
added test cases for windows powershell & bash
Rusted2361 0f0717f
Merge branch 'trufflesecurity:main' into fix/issue-4578-incorrect-pat…
Rusted2361 3036f89
Merge branch 'main' into fix/issue-4578-incorrect-paths-on-windows
kashifkhan0771 cfc3221
Merge branch 'main' into fix/issue-4578-incorrect-paths-on-windows
Rusted2361 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.