Fix/issue 4578 path normalization for unix and windows #4614
+23
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rusted2361
changed the title
Author
|
@kashifkhan0771 please review this PR |
kashifkhan0771
approved these changes
Dec 26, 2025
Contributor
|
Approved from my side, but these changes also require approval from @trufflesecurity/product-eng. Unfortunately, most of the team is currently out on holidays, so we’ll need to wait a bit. Thanks for the PR - once the team is back, we’ll get it merged 🙂 |
Author
|
@kashifkhan0771 sorry to ping you can you @ mention rufflesecurity/product-eng team to review the PR :) |
kashifkhan0771
requested review from
camgunz,
martinlocklear and
trufflesteeeve
rosecodym
reviewed
Jan 6, 2026
Contributor
rosecodym
left a comment
rosecodym
left a comment
There was a problem hiding this comment.
Thanks for this! It seems like a great candidate for some new automated tests - would you mind adding some?
shahzadhaider1
approved these changes
Jan 13, 2026
camgunz
requested changes
Jan 14, 2026
Author
|
@rosecodym please review & merge this one if it looks good to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue described in below ticket was regenerated and fixed in this PR.
#4578
Resolves issues with cloning local Git repositories on Windows: