Skip to content

fix(GenericRandomErrorPlugin): match all methods when method not specified #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waldekmastykarz wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

fix(GenericRandomErrorPlugin): match all methods when method not specified #1504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion DevProxy.Plugins/Behavior/GenericRandomErrorPlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,8 @@ private ThrottlingInfo ShouldThrottle(Request request, string throttlingKey)
return false;
}

if (errorResponse.Request.Method != request.Method)
if (errorResponse.Request.Method is not null &&
errorResponse.Request.Method != request.Method)
{
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion DevProxy.Plugins/Models/GenericErrorResponse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public class GenericErrorResponse
public class GenericErrorResponseRequest
{
public string? BodyFragment { get; set; }
public string Method { get; set; } = "GET";
public string? Method { get; set; }
public string Url { get; set; } = string.Empty;
}

Expand Down
Loading