fix(GenericRandomErrorPlugin): match all methods when method not specified #1504
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ified When a mock error response doesn't specify a method, the plugin now matches all HTTP methods instead of only GET requests. Previously, the Method property defaulted to 'GET', causing non-GET requests to fail matching when no method was specified in the config. Fixes dotnet#1503
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the GenericRandomErrorPlugin where error responses without a specified HTTP method would only match GET requests instead of matching all HTTP methods. The fix makes the Method property nullable and updates the matching logic to skip method comparison when the method is not specified.
Changes:
- Made the
Methodproperty nullable inGenericErrorResponseRequestto distinguish between "no method specified" and "specific method specified" - Updated the request matching logic to only check method equality when a method is explicitly configured
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| DevProxy.Plugins/Models/GenericErrorResponse.cs | Changed Method property from non-nullable with default value "GET" to nullable without default |
| DevProxy.Plugins/Behavior/GenericRandomErrorPlugin.cs | Added null check before comparing method to skip comparison when method is not specified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1503
When a mock error response doesn't specify a method, the
GenericRandomErrorPluginnow matches all HTTP methods instead of only GET requests.Changes
Methodproperty inGenericErrorResponseRequestnullableBefore
{ "request": { "url": "https://api.example.com/*" }, "responses": [...] }This would only match GET requests because
Methoddefaulted to"GET".After
The same config now matches all HTTP methods (GET, POST, PUT, DELETE, etc.).
To match a specific method, explicitly set it:
{ "request": { "url": "https://api.example.com/*", "method": "POST" }, "responses": [...] }