Skip to content

Changed error message when snapshot is not on secondary when trying to perform download #12462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tonitzpp wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Changed error message when snapshot is not on secondary when trying to perform download #12462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,8 +578,9 @@ public String extractSnapshot(ExtractSnapshotCmd cmd) {
}

if (ObjectUtils.anyNull(chosenStore, snapshotDataStoreReference)) {
logger.error("Snapshot [{}] not found in any secondary storage.", snapshot);
throw new InvalidParameterValueException("Snapshot not found.");
String errorMessage = String.format("Snapshot [%s] not found in any secondary storage. The snapshot may be on primary storage, where it cannot be downloaded.", snapshot.getUuid());
logger.error(errorMessage);
throw new InvalidParameterValueException(errorMessage);
}

snapshotSrv.syncVolumeSnapshotsToRegionStore(snapshot.getVolumeId(), chosenStore);
Expand Down
Loading