Skip to content

Conversation

@Tonitzpp
Copy link
Contributor

Description

Currently, when trying to download a snapshot that is in primary storage, the error message Snapshot not found is shown, which may lead users into thinking that the snapshot does not exist in any storage anymore. This PR changes the message to Snapshot not found in any secondary storage. The snapshot may be on primary storage, where it cannot be downloaded.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale

  • Major
  • Minor

How Has This Been Tested?

A VM was created to perform the tests. After that Global Settings tab was accessed and the configuration snapshot.backup.to.secondary was set to false. After this change, I took a volume snapshot and tried to download it, and it was possible to validate that the shown message was changed.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.85%. Comparing base (46cb805) to head (9b58932).
⚠️ Report is 52 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12462      +/-   ##
============================================
+ Coverage     17.60%   17.85%   +0.24%     
- Complexity    15668    15983     +315     
============================================
  Files          5915     5929      +14     
  Lines        529967   531046    +1079     
  Branches      64734    64913     +179     
============================================
+ Hits          93304    94794    +1490     
+ Misses       426195   425637     -558     
- Partials      10468    10615     +147     
Flag Coverage Δ
uitests 3.58% <ø> (+<0.01%) ⬆️
unittests 18.94% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants