Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 20, 2026

Addresses portability feedback on #356 regarding non-POSIX compliant echo -e usage in the generated install-wp-tests.sh template.

Changes

  • Replaced all echo -e statements with printf for POSIX-compliant escape sequence handling
  • Ensures the script works reliably across minimal sh implementations and various Unix-like systems

Example

Before:

echo -e "\033[0;32mSuccess message\033[0m"

After:

printf "\033[0;32mSuccess message\033[0m\n"

While the bash shebang (#!/usr/bin/env bash) makes echo -e functional, printf is the more portable and standard approach for formatted output with escape sequences.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Update install-wp-tests.sh script based on review feedback Replace echo -e with printf in install-wp-tests.sh for POSIX compliance Jan 20, 2026
Copilot AI requested a review from swissspidy January 20, 2026 20:15
@swissspidy swissspidy marked this pull request as ready for review January 20, 2026 20:53
@swissspidy swissspidy merged commit 40c1d42 into try/322-refresh Jan 20, 2026
1 check passed
@swissspidy swissspidy deleted the copilot/sub-pr-356 branch January 20, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants