Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 20, 2026

Addresses feedback on PR #356 regarding command availability checks in the install-wp-tests.sh template.

Changes

Replaced all which command invocations with command -v for:

  • mariadb-admin checks in recreate_db() and create_db()
  • mariadb check in install_db()
  • curl/wget checks in download()

Rationale

command -v is POSIX-compliant and reliably validates command executability. which may return paths to non-executable files and has inconsistent behavior across systems.

Before:

if [ `which mariadb-admin` ]; then
    mariadb-admin create $DB_NAME

After:

if command -v mariadb-admin > /dev/null 2>&1; then
    mariadb-admin create $DB_NAME

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 20, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • example.com
    • Triggering command: /usr/bin/php /usr/bin/php /home/REDACTED/work/scaffold-command/scaffold-command/vendor/wp-cli/wp-cli/bin/../php/boot-fs.php core install --url=REDACTED --title=WP CLI Site --admin_user=admin --admin_email=admin@example.com --admin_password=password1 --skip-email (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Address feedback on updates to install-wp-tests.sh script Replace which with command -v in install-wp-tests.sh Jan 20, 2026
Copilot AI requested a review from swissspidy January 20, 2026 11:21
@swissspidy swissspidy marked this pull request as ready for review January 20, 2026 11:40
@swissspidy swissspidy requested a review from a team as a code owner January 20, 2026 11:40
@swissspidy swissspidy merged commit 88e06b0 into try/322-refresh Jan 20, 2026
10 of 43 checks passed
@swissspidy swissspidy deleted the copilot/sub-pr-356 branch January 20, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants