-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add support for storing query results to cloud storage #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mpetazzoni
wants to merge
12
commits into
main
Choose a base branch
from
max/feature/store-results-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3468475 to
605dc8b
Compare
Member
Author
|
Replaces #39. |
a6d11c2 to
1126739
Compare
- Move enums (ExecutionState, RequestKind, EventKind, etc.) from constants.py to types.py - Move dataclasses (Store, StoreResult, ExecutionResult) from store.py/results.py to models.py - Delete store.py and results.py - Update all imports across the codebase
1126739 to
3c57867
Compare
Contributor
|
@mpetazzoni i assume this supercedes #39? |
Member
Author
Yes, I commented that above. |
Contributor
ah sorry, i missed that comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for the
storecapability from the SQL API, allowing query results to be stored in cloud storage instead of being returned directly over the WebSocket connection.Storeconfiguration class withfor_download()convenience methodStorageFormatenum (parquet, csv, geojson)StoreResultdataclass to capture the result URI and sizestoreparameter tocursor.execute()cursor.get_store_result()method to retrieve store resultstypes.py,models.py)Usage