Skip to content

Conversation

@alexanderankin
Copy link
Member

@alexanderankin alexanderankin commented Nov 14, 2025

I accidentally pushed this code in the previous commit, this PR associates itself with the change so the git history makes sense later. as well as fix the bug

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.70%. Comparing base (49c9af8) to head (45d17d4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
+ Coverage   77.71%   78.70%   +0.98%     
==========================================
  Files          14       14              
  Lines        1216     1216              
  Branches      142      142              
==========================================
+ Hits          945      957      +12     
+ Misses        231      218      -13     
- Partials       40       41       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexanderankin alexanderankin changed the title fix: ci fix(core): restore dind test Jan 24, 2026
@alexanderankin alexanderankin marked this pull request as ready for review January 24, 2026 17:47
@alexanderankin
Copy link
Member Author

@CarliJoy thoughts before i merge?

@CarliJoy
Copy link
Contributor

LGTM.

I am not sure that we require logger output within tests instead of simple print. But this is a question of taste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants