-
-
Notifications
You must be signed in to change notification settings - Fork 4
fix: Remove incorrect status service #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lfrancke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM code-wise but maybe there was some intention here that I'm missing
sbernauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for the record:
I only added status.service back than because the docs state it's required in https://www.openpolicyagent.org/docs/configuration#status.
Looks like the docs are wrong.
But anyway, we even added a metrics assertion to the smoke test in that PR, so as long as the test passes I don't care to be honest.
Checked with @sbernauer:
|
Description
Fixes #798.
Status updates are currently sent to prometheus (correct) and the bundle-builder service, which exposes a status endpoint, but does not offer one to POST to. This has been removed.
The config now changes from
{ ... "status": { "service": "stackable" "prometheus": true } }to
{ ... "status": { "prometheus": true } }and log outputs showing previously
now show
Jenins 🟢 https://testing.stackable.tech/job/opa-operator-it-custom/36
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker