Skip to content

refactor(ast): Removed redundant type ast.Expr #4273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asmyasnikov wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −23
Open

refactor(ast): Removed redundant type ast.Expr #4273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions internal/engine/sqlite/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,10 +311,6 @@ func (c *cc) convertFuncContext(n *parser.Expr_functionContext) ast.Node {
return todo("convertFuncContext", n)
}

func (c *cc) convertExprContext(n *parser.ExprContext) ast.Node {
return &ast.Expr{}
}

func (c *cc) convertColumnNameExpr(n *parser.Expr_qualified_column_nameContext) *ast.ColumnRef {
var items []ast.Node
if schema, ok := n.Schema_name().(*parser.Schema_nameContext); ok {
Expand Down Expand Up @@ -826,7 +822,7 @@ func (c *cc) convertUnaryExpr(n *parser.Expr_unaryContext) ast.Node {
if opCtx.MINUS() != nil {
// Negative number: -expr
return &ast.A_Expr{
Name: &ast.List{Items: []ast.Node{&ast.String{Str: "-"}}},
Name: &ast.List{Items: []ast.Node{&ast.String{Str: "-"}}},
Rexpr: expr,
}
}
Expand All @@ -837,7 +833,7 @@ func (c *cc) convertUnaryExpr(n *parser.Expr_unaryContext) ast.Node {
if opCtx.TILDE() != nil {
// Bitwise NOT: ~expr
return &ast.A_Expr{
Name: &ast.List{Items: []ast.Node{&ast.String{Str: "~"}}},
Name: &ast.List{Items: []ast.Node{&ast.String{Str: "~"}}},
Rexpr: expr,
}
}
Expand Down Expand Up @@ -1267,9 +1263,6 @@ func (c *cc) convert(node node) ast.Node {
case *parser.Delete_stmt_limitedContext:
return c.convertDelete_stmtContext(n)

case *parser.ExprContext:
return c.convertExprContext(n)

case *parser.Expr_functionContext:
return c.convertFuncContext(n)

Expand Down
8 changes: 0 additions & 8 deletions internal/sql/ast/expr.go
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions internal/sql/astutils/rewrite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,9 +724,6 @@ func (a *application) apply(parent ast.Node, name string, iter *iterator, n ast.
a.apply(n, "Query", nil, n.Query)
a.apply(n, "Options", nil, n.Options)

case *ast.Expr:
// pass

case *ast.FetchStmt:
// pass

Expand Down
3 changes: 0 additions & 3 deletions internal/sql/astutils/walk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,9 +1134,6 @@ func Walk(f Visitor, node ast.Node) {
Walk(f, n.Options)
}

case *ast.Expr:
// pass

case *ast.FetchStmt:
// pass

Expand Down
Loading