test: use node test runner to assert expected cases #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimeg
requested review from
WilliamBergamin,
misscoded,
mwbrooks and
srtaalej
zimeg
added
dependencies
Member
Author
|
🔬 Hmm... I'm not sure coverage reports are generated as noted in codecov/feedback#107 for Node 20? Perhaps this is saved as a draft PR for now, or coverage is checked otherwise in the meantime. Open to suggestions! |
WilliamBergamin
approved these changes
Jan 22, 2026
| "lint:fix": "biome check --write", | ||
| "lint": "biome check", | ||
| "test": "c8 mocha test/*.spec.js", | ||
| "test": "node --test --experimental-test-coverage test/*.spec.js", |
Contributor
There was a problem hiding this comment.
This is awesome 💯 it would allow us to reduce our dependencies
My only concern here is that --experimental-test-coverage is still experimental and subject to breaking changes and potential removal, I haven't been able to find a stable target release date for it.
I'm not opposed to testing this out on this project but we need to be ready to potentially roll this back if the feature changes or gets removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses the
node:testpackage to assert expected cases in place of the amazingmochaandchaipackages ☕ 🫡Notes
Also removed are the kind packages adjacent: 💌
@types/chai@types/mochac8mocha-suppress-logsCoverage is changed from
c8to--experimental-test-coveragewhich is checking both "src" and "test" directories but updates for #487 might bring options to change this also 🧪Requirements