Skip to content

Conversation

@icecrasher321
Copy link
Collaborator

@icecrasher321 icecrasher321 commented Jan 18, 2026

Summary

Few tools missing properties fields that enable tag dropdown

Type of Change

  • Other: UX Improvement

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Jan 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Skipped Skipped Jan 18, 2026 8:33pm

Request Review

@icecrasher321 icecrasher321 changed the title impovement(slides): add missing properties definitions for metadata improvement(slides): add missing properties definitions for metadata Jan 18, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 18, 2026

Greptile Summary

This PR systematically adds missing properties field definitions to the metadata output across all 14 Google Slides tools. The properties definitions enable the tag dropdown UI feature, allowing users to select specific metadata fields (like presentationId, url, title) as tags in the workflow interface.

Key Changes:

  • Added structured properties definitions for metadata outputs in all Google Slides tools
  • Each property includes type and description fields following the OutputProperty interface pattern
  • The write.ts tool received additional improvements: better error handling for invalid slide indices and proper metadata initialization before validation
  • Properties are consistent with the actual metadata returned by transformResponse functions
  • All definitions follow the existing pattern from apps/sim/tools/types.ts (OutputProperty interface)

Bonus Improvements in write.ts:

  • Moved metadata construction earlier in the function for better error handling
  • Added validation for slideIndex (NaN check and negative number check)
  • Replaced thrown errors with proper error responses containing metadata
  • Improved error flow to return structured responses instead of throwing exceptions

The changes are purely additive and improve UX without altering runtime behavior.

Confidence Score: 5/5

  • Safe to merge - purely additive metadata definitions with bonus error handling improvements
  • All changes are non-breaking additions that enhance UX by enabling tag dropdown functionality. The property definitions accurately match the metadata structure returned by each tool. The write.ts improvements follow best practices for error handling.
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/tools/google_slides/add_image.ts Added properties definitions for metadata output (presentationId, pageObjectId, imageUrl, url)
apps/sim/tools/google_slides/add_slide.ts Added properties definitions for metadata output (presentationId, layout, insertionIndex, url)
apps/sim/tools/google_slides/create.ts Added properties definitions for metadata output (presentationId, title, mimeType, url)
apps/sim/tools/google_slides/read.ts Added properties definitions for metadata output including nested pageSize object with width/height properties
apps/sim/tools/google_slides/write.ts Added properties definitions for metadata output and improved error handling with better validation

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Tool as Google Slides Tool
    participant UI as Tag Dropdown UI
    participant API as Google Slides API

    Dev->>Tool: Add properties definitions to outputs.metadata
    Note over Tool: Define metadata structure with<br/>presentationId, title, url, etc.
    
    Tool->>UI: Expose structured metadata properties
    UI->>UI: Parse properties field
    UI->>UI: Enable tag dropdown for metadata fields
    
    Note over Dev,UI: UX Improvement: Users can now<br/>select specific metadata fields as tags
    
    rect rgb(200, 220, 240)
        Note over Tool,API: Runtime execution flow (unchanged)
        Tool->>API: Execute Google Slides operation
        API-->>Tool: Return response
        Tool->>Tool: Transform response to output format
        Tool-->>Dev: Return structured output with metadata
    end
Loading

@icecrasher321 icecrasher321 merged commit 5e2468c into staging Jan 18, 2026
11 checks passed
@icecrasher321 icecrasher321 deleted the improvement/gslides branch January 18, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants