Fix tests: Intermittent FK constraint violation on polymorphic_ctype_id #2876
+24
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2567 documents intermittent failures on tests involving the polymorphic models in the sponsors directory. The exception is always along the lines of:
django-polymorphic uses the
polymorphic_ctypefield to track the concrete instance type on the base table. It sets this field automatically. Whats happening here is that model bakery is overriding this field and setting it to a random content type. Most of the time this passed the foreign key constraint - butContentTypeobjects are cached andmailing/tests/models.pycreated a temporary model (MockEmailTemplate) in a transaction that is rolled back after the mailing tests are complete. The cache that model bakery was drawing content types from was not cleared however. You get the fk constraint error when it happened to randomly set the content type of a polymorphic model toMockEmailTemplate.There are two parts to the fix here:
Closes