Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Lib/functools.py
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,9 @@ def decorating_function(user_function):
return decorating_function

def _lru_cache_wrapper(user_function, maxsize, typed, _CacheInfo):
if not callable(user_function):
Copy link
Member

@picnixz picnixz Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this check in lru_wrapper directly? it should only be done in def decorating_function() I think.

We are doing the check twice otherwise (when we do not call the decorator with ())

raise TypeError("the first argument must be callable")

# Constants shared by all lru cache instances:
sentinel = object() # unique object used to signal cache misses
make_key = _make_key # build a key from the function arguments
Expand Down
7 changes: 7 additions & 0 deletions Lib/test/test_functools.py
Original file line number Diff line number Diff line change
Expand Up @@ -2157,6 +2157,13 @@ def fib(n):
with self.assertRaises(RecursionError):
fib(support.exceeds_recursion_limit())

def test_lru_checks_arg_is_callable(self):
with self.assertRaisesRegex(
TypeError,
"the first argument must be callable",
):
self.module.lru_cache(1)('hello')


@py_functools.lru_cache()
def py_cached_func(x, y):
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
The Python implementation of :func:`functools.lru_cache` differed from the
default C implementation in that it did not check that its argument is
callable. This discrepancy is now fixed and both raise a :class:`TypeError`.
Copy link
Contributor

@aisk aisk Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More specifically:

Suggested change
callable. This discrepancy is now fixed and both raise a :class:`TypeError`.
callable. This discrepancy is now fixed and both raise a :exc:`TypeError`.

Loading