-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-144012: Check null binary op extend #144014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, does this need backporting?
I think it should, the 3.14 branch doesn’t check it either: Lines 825 to 826 in 23e3c0a
And 3.13 branch don't have this opcode, so we can just backport it to 3.14. |
|
Thanks @aisk for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @aisk and @Fidget-Spinner, I could not cleanly backport this to |
|
@aisk can you please handle the backport? Thank you! |
Will work on this later today. |
|
GH-144038 is a backport of this pull request to the 3.14 branch. |
(cherry picked from commit 54bedcf) Co-authored-by: AN Long <aisk@users.noreply.github.com>
BINARY_OP_EXTEND#144012