🐛 Refactor ClusterExtensionRevision controller to rely on kubernetes for resource cleanup

[perdasilva]

Description

The ClusterExtensionRevision controller uses the Boxcutter library to teardown the revision and delete the revision objects from the cluster. This process uses the RevisionEngine's client. The recent move to use the scoped client for revision resource management puts a dependency between the teardown process and the service account and its rbac. When doing a "GitOps style" deletion (i.e. uninstalling a ClusterExtension by deleting the extension, service account, and rbac objects in unison), the service account backing the teardown process is not guaranteed to be there and this results in bundle resources persisting on the cluster.

This PR updates the ClusterExtensionRevision controller to rely on Kubernetes for the deletion and clean up of the revision resources. Since the controller already sets up the appropriate ownerrefs, its sufficient to just remove the call to the RevisionEngine Teardown method.

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	586d4b9
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/696f95ae0b6d9b0008ba58f2
😎 Deploy Preview	https://deploy-preview-2451--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[rashmigottipati]

/lgtm

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.42%. Comparing base (a9e5614) to head (586d4b9).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2451      +/-   ##
==========================================
- Coverage   73.01%   69.42%   -3.59%     
==========================================
  Files         101      101              
  Lines        7730     7716      -14     
==========================================
- Hits         5644     5357     -287     
- Misses       1635     1925     +290     
+ Partials      451      434      -17     

Flag	Coverage Δ
e2e	46.25% <0.00%> (+<0.01%)	⬆️
experimental-e2e	13.53% <0.00%> (-36.22%)	⬇️
unit	57.05% <100.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[tmshort]

/approve

[camilamacedo86]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86,tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

/override codecov/project

[openshift-ci]

@camilamacedo86: Overrode contexts on behalf of camilamacedo86: codecov/project

Details

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.