learn(frame-graphs): update the ways to view flame graphs #8555
Conversation
Updated instructions for generating and visualizing flame graphs, including browser preview and local setup options. Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/diagnostics Please review the changes when you have a chance. Thank you! 🙏 |
There was a problem hiding this comment.
Pull request overview
This PR updates the flame graphs documentation to provide users with an additional browser-based option for visualizing flame graphs using flamegraph.com, eliminating the need to clone and set up the FlameGraph tools locally.
Changes:
- Added browser-based preview option using flamegraph.com website
- Restructured step 6 to present two alternatives: browser preview and local FlameGraph tools setup
- Updated the follow-up text to be more generic and apply to both visualization methods
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8555 +/- ##
==========================================
+ Coverage 74.96% 74.97% +0.01%
==========================================
Files 103 103
Lines 9036 9036
Branches 312 312
==========================================
+ Hits 6774 6775 +1
+ Misses 2260 2259 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
📦 Build Size ComparisonSummary
Changes➕ Added Assets (1)
➖ Removed Assets (1)
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Description
I’ve just discovered this page that has been helping me preview flame graphs, and it could be useful for others as well, avoiding the need to clone another package.
Validation
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.