Skip to content

impr(quotes): add english quotes (@hmonwutt) #7427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
HmonWutt wants to merge 2 commits into
base: master
Choose a base branch
from
Open

impr(quotes): add english quotes (@hmonwutt) #7427

HmonWutt wants to merge 2 commits into from
+18 −0

Conversation

@HmonWutt
Copy link

@HmonWutt HmonWutt commented Jan 22, 2026

Description

Added three English quotes.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language?
    • Make sure to follow the languages documentation
    • Add language to packages/schemas/src/languages.ts
    • Add language to exactly one group in frontend/src/ts/constants/languages.ts
    • Add language json file to frontend/static/languages
  • Adding a theme?
    • Make sure to follow the themes documentation
    • Add theme to packages/schemas/src/themes.ts
    • Add theme to frontend/src/ts/constants/themes.ts
    • (optional) Add theme css file to frontend/static/themes
    • Add some screenshots of the theme, especially with different test settings (colorful, flip colors) to your pull request
  • Adding a layout?
    • Make sure to follow the layouts documentation
    • Add layout to packages/schemas/src/layouts.ts
    • Add layout json file to frontend/static/layouts
  • Adding a font?
    • Make sure to follow the fonts documentation
    • Add font file to frontend/static/webfonts
    • Add font to packages/schemas/src/fonts.ts
    • Add font to frontend/src/ts/constants/fonts.ts
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

Copilot AI review requested due to automatic review settings January 22, 2026 23:59
@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Jan 22, 2026
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Jan 22, 2026
Copilot AI reviewed Jan 23, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds three English quotes from Terry Pratchett to the quotes database. The quotes are properly structured with correct IDs, lengths, and sources.

Changes:

  • Added three Terry Pratchett quotes (IDs 7738-7740) to the English quotes collection

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frontend/static/quotes/english.json Outdated
},
{
"text": "The trouble with having an open mind, of course, is that people will insist on coming along and trying to put things in it.",
"source": "Terry Prachett, Diggers",
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The author's name is misspelled. It should be "Terry Pratchett" with two 't's, not "Terry Prachett".

Copilot uses AI. Check for mistakes.
frontend/static/quotes/english.json Outdated

{
"text": "Wisdom comes from experience. Experience is often a result of lack of wisdom.",
"source": "Terry Prachett",
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The author's name is misspelled. It should be "Terry Pratchett" with two 't's, not "Terry Prachett".

Copilot uses AI. Check for mistakes.
frontend/static/quotes/english.json Outdated
},
{
"text": "The intelligence of that creature known as a crowd is the square root of the number of people in it.",
"source": "Terry Prachett, Jingo",
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The author's name is misspelled. It should be "Terry Pratchett" with two 't's, not "Terry Prachett".

Copilot uses AI. Check for mistakes.
frontend/static/quotes/english.json Outdated
"id": 7738,
"length": 123
},

Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the blank line between quote entries. The rest of the file does not have blank lines between quote objects, only commas separating them.

Copilot uses AI. Check for mistakes.
@HmonWutt
Copy link
Author

HmonWutt commented Jan 23, 2026

@copilot open a new pull request to apply changes based on the comments in this thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

assets Languages, themes, layouts, etc. frontend User interface or web stuff waiting for review Pull requests that require a review before continuing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HmonWutt @monkeytypegeorge