-
Notifications
You must be signed in to change notification settings - Fork 663
Read bound address from server.address() and handle IPv6 formatting #5557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TheLarkInn
merged 8 commits into
bmiddha/playwright-browser-server
from
copilot/sub-pr-5424-another-one
Jan 22, 2026
Merged
Read bound address from server.address() and handle IPv6 formatting #5557
TheLarkInn
merged 8 commits into
bmiddha/playwright-browser-server
from
copilot/sub-pr-5424-another-one
Jan 22, 2026
+32
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com>
…Pv4 or IPv6 Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com>
Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com>
Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com>
Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com>
Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com>
Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update implementation based on feedback for Playwright browser server
Read bound address from server.address() and handle IPv6 formatting
Jan 22, 2026
TheLarkInn
approved these changes
Jan 22, 2026
TheLarkInn
added a commit
that referenced
this pull request
Jan 22, 2026
…5557) * Initial plan * Read IP address from server.address() and handle IPv6 formatting Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com> * Use 'localhost' instead of hardcoded IPv4 to allow system to choose IPv4 or IPv6 Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com> * Rename address variable to formattedAddress for clarity Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com> * Add null check and handle both string and number IPv6 family values Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com> * Import AddressInfo from node:net and fix IPv6 family check Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com> * Improve type safety for server.address() return value Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com> * Extract formatAddress helper and improve error messages Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HttpServerwas hardcoding127.0.0.1for the endpoint URL instead of reading the actual bound address, and lacked IPv6 support.Changes
server.address()instead of assuming hardcoded values[address]:port, IPv4 asaddress:port'localhost': Changed from'127.0.0.1'to allow system DNS resolution to choose IPv4 (127.0.0.1) or IPv6 (::1) loopbackAddressInfofromnode:net, add guards fornulland string pipe pathsformatAddress()helper: Centralize formatting logic with proper IPv6 detection💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.