Skip to content

Conversation

@tankyleo
Copy link
Contributor

When the node is idle, the info level was quite spammy. It is now quiet.

When the node is idle, the info level was quite spammy. It is now quiet.
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jan 19, 2026

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Copy link
Contributor

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, however might be useful to just have a single info log that says each time a sync happens.

@tankyleo
Copy link
Contributor Author

tankyleo commented Jan 19, 2026

lgtm, however might be useful to just have a single info log that says each time a sync happens.

My intention is to avoid periodic information logs at the info level. I want to let the node sit for a week, and if nothing happened, no issues, nothing out of the ordinary, then no logs :)

Maybe I could just watch Warn and Error, but if I am generating an address for example, or connecting to a peer / opening a channel, that should be an info, not a warn. And I won't want these events to be hidden among the many "sync happened" logs over a week.

Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not super opposed to these concrete changes, but in general we should expose more actionable information on INFO and DEBUG levels, as currently it's hardly exposing any information on INFO.

FWIW, as recently mentioned we should rework the log-level concept across crates at some point (soon), then maybe also tackling or closing #481 for instance.

Anyways, going ahead and landing this for now, mostly as we currently assume (and default to) users running on DEBUG anyways.

@tnull tnull merged commit c99d09d into lightningdevkit:main Jan 19, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants