Skip to content

HCK-14275: Generate SQL for view column comments #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Vitalii4as merged 1 commit into from
Jan 15, 2026
Merged

HCK-14275: Generate SQL for view column comments #181

Vitalii4as merged 1 commit into from
Jan 15, 2026

Conversation

@AlikRakhmonov
Copy link
Contributor

@AlikRakhmonov AlikRakhmonov commented Jan 15, 2026 •
edited
Loading

Sub-taskHCK-14275 [PostgreSQL] FE: add comment on VIEW column (same script gen option as for TABLE column)

Technical details

  1. Refactor code: remove duplicates, use shared methods to get items from the Delta model.
  2. Reuse the table column comments helper for view column comments.
  3. Escape comments only when they have special characters. (E'...')

@AlikRakhmonov AlikRakhmonov marked this pull request as draft January 15, 2026 10:05
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 15, 2026

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@AlikRakhmonov AlikRakhmonov self-assigned this Jan 15, 2026
@AlikRakhmonov AlikRakhmonov marked this pull request as ready for review January 15, 2026 12:02
@Vitalii4as Vitalii4as merged commit f5d89dd into develop Jan 15, 2026
6 of 8 checks passed
@Vitalii4as Vitalii4as deleted the HCK-14275 branch January 15, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vitalii4as Vitalii4as Vitalii4as approved these changes

@chulanovskyi-bs chulanovskyi-bs Awaiting requested review from chulanovskyi-bs

Assignees

@AlikRakhmonov AlikRakhmonov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlikRakhmonov @Vitalii4as