-
Notifications
You must be signed in to change notification settings - Fork 438
impl(v3): bzlmod support for otel v1.24 #15906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: prepare-for-v3.0.0
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on upgrading the OpenTelemetry C++ library to its latest version, 1.24.0, to leverage recent improvements and maintain compatibility. It also includes necessary adjustments to the Bazel build configuration for explicit ABI versioning and updates to test mocks to align with the new OpenTelemetry API. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the OpenTelemetry dependency to version 1.24.0 and adds bzlmod support. The changes include updating the dependency version in MODULE.bazel, removing a now-redundant crc32c dependency, adding a new build flag for bzlmod in .bazelrc, and updating the MockMeter in metrics_test.cc to reflect API changes in the new OpenTelemetry version. The changes are correct and well-implemented. I have no specific comments.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## prepare-for-v3.0.0 #15906 +/- ##
===================================================
Coverage 92.82% 92.83%
===================================================
Files 2354 2354
Lines 216300 216300
===================================================
+ Hits 200778 200798 +20
+ Misses 15522 15502 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.