Skip to content

Fix Storybook 10 compatibility after Dependabot upgrade #4262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Fix Storybook 10 compatibility after Dependabot upgrade #4262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
52f4688
Bump the storybook group across 1 directory with 7 updates
dependabot[bot] Jan 15, 2026
2fc2f96
Initial plan
Copilot Jan 19, 2026
06d4c69
Fix Storybook imports and upgrade to v10 compatibility
Copilot Jan 19, 2026
794be4c
Initial plan
Copilot Jan 19, 2026
6fffa5c
Fix Storybook build by converting preset.ts to ES modules and tempora…
Copilot Jan 19, 2026
ad70ecd
Re-enable MDX support for Storybook v10
Copilot Jan 19, 2026
6a1c391
Initial plan
Copilot Jan 19, 2026
45b5828
Fix TypeScript type errors in event handlers and refs
Copilot Jan 19, 2026
1d805dd
Fix MethodRow ref types to match DataGridCell
Copilot Jan 19, 2026
42b1cb7
Fix useRef type in MethodRow parent component
Copilot Jan 19, 2026
e01f33c
Merge pull request #4264 from github/copilot/fix-github-actions-workf…
d10c Jan 20, 2026
849f2a4
Merge pull request #4263 from github/copilot/fix-github-actions-workf…
d10c Jan 20, 2026
e1bc98f
Fix Overview.mdx for Storybook 10 compatibility
Copilot Jan 20, 2026
d7cfd8c
Fix ThemeSelector imports and revert ModelTypeTextbox type changes
Copilot Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions extensions/ql-vscode/.storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,15 @@ import type { StorybookConfig } from "@storybook/react-vite";
const config: StorybookConfig = {
stories: ["../src/**/*.mdx", "../src/**/*.stories.@(js|jsx|ts|tsx)"],
addons: [
"@storybook/addon-docs",
"@storybook/addon-links",
"@storybook/addon-essentials",
"@storybook/addon-interactions",
"@storybook/addon-a11y",
"./vscode-theme-addon/preset.ts",
],
framework: {
name: "@storybook/react-vite",
options: {},
},
docs: {
autodocs: "tag",
},
};

export default config;
4 changes: 2 additions & 2 deletions extensions/ql-vscode/.storybook/manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { addons } from "@storybook/manager-api";
import { themes } from "@storybook/theming";
import { addons } from "storybook/manager-api";
import { themes } from "storybook/theming";

addons.setConfig({
theme: themes.dark,
Expand Down
5 changes: 3 additions & 2 deletions extensions/ql-vscode/.storybook/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { Preview } from "@storybook/react";
import { themes } from "@storybook/theming";
import { action } from "@storybook/addon-actions";
import { themes } from "storybook/theming";
import { action } from "storybook/actions";

// Allow all stories/components to use Codicons
import "@vscode/codicons/dist/codicon.css";
Expand All @@ -20,6 +20,7 @@ window.acquireVsCodeApi = () => ({

// https://storybook.js.org/docs/react/configure/overview#configure-story-rendering
const preview: Preview = {
tags: ["autodocs"],
parameters: {
// All props starting with `on` will automatically receive an action as a prop
actions: { argTypesRegex: "^on[A-Z].*" },
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/.storybook/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"compilerOptions": {
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"target": "es2021",
"outDir": "out",
"lib": ["ES2021", "dom"],
Expand Down
4 changes: 2 additions & 2 deletions extensions/ql-vscode/.storybook/vscode-theme-addon/ThemeSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ import * as React from "react";
import type { FunctionComponent } from "react";
import { useCallback } from "react";

import { useGlobals } from "@storybook/manager-api";
import { useGlobals } from "storybook/manager-api";
import {
IconButton,
TooltipLinkList,
Comment on lines 6 to 8
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import for components should use storybook/internal/components instead of @storybook/components to be consistent with Storybook 10's consolidated package structure. The PR description mentions this update was made in commit ef85f1d, but this file still imports from the old v8 path.

See below for a potential fix:

} from "storybook/internal/components";

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit d7cfd8c. Updated the import to use storybook/internal/components.

WithTooltip,
} from "@storybook/components";
} from "storybook/internal/components";
import { DashboardIcon } from "@storybook/icons";

import { themeNames, VSCodeTheme } from "./theme";
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/.storybook/vscode-theme-addon/manager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from "react";
import { addons } from "@storybook/manager-api";
import { addons } from "storybook/manager-api";
import { Addon_TypesEnum } from "storybook/internal/types";
import { ThemeSelector } from "./ThemeSelector";

Expand Down
9 changes: 7 additions & 2 deletions extensions/ql-vscode/.storybook/vscode-theme-addon/preset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
import { dirname, join } from "path";
import { fileURLToPath } from "url";

const __dirname = dirname(fileURLToPath(import.meta.url));

export function previewAnnotations(entry = []) {
return [...entry, require.resolve("./preview.ts")];
return [...entry, join(__dirname, "preview.ts")];
}

export function managerEntries(entry = []) {
return [...entry, require.resolve("./manager.tsx")];
return [...entry, join(__dirname, "manager.tsx")];
}
Loading