-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Enhance the skill to include sampling of data, to detect better joins. #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the Snowflake semantic views skill by adding guidance for data sampling to better detect joins and relationships between tables. The changes include renaming the skill from snowflake-semanticview to snowflake-semantic-views and adding instructions for sampling data, validating with queries, and improving the workflow steps.
Changes:
- Added data sampling step (step 5) with SELECT DISTINCT queries limited to 1000 rows for discovering relationships and data types
- Added example query syntax (step 10) for validating the final semantic view works correctly
- Renamed the skill from
snowflake-semanticviewtosnowflake-semantic-viewsin both the SKILL.md name field and README table - Renumbered subsequent workflow steps to accommodate the new additions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| skills/snowflake-semanticview/SKILL.md | Updated skill name, added data sampling step, added validation query example, and renumbered workflow steps |
| docs/README.skills.md | Updated skill name reference in the skills table to match new name |
…wflake-semanticview'
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.Description
An update to an existing skill.
Type of Contribution
Additional Notes
Added some paragraphs to the .md file, for better guidance to the agent.
By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.