Skip to content

Conversation

@ilopezluna
Copy link
Contributor

@ilopezluna ilopezluna commented Jan 20, 2026

Add support to install diffusers backend via docker model install-runner --backend diffusers

The variant requires 2GB on disk:

REPOSITORY                            TAG                IMAGE ID       CREATED          SIZE      SHARED SIZE   UNIQUE SIZE   CONTAINERS
docker/model-runner                   latest-vllm-cuda   90fe2f9a683c   2 minutes ago    9.61GB    0B            9.606GB       0
docker/model-runner                   latest             5a864a6b6adc   5 minutes ago    827MB     624.7MB       202.3MB       0
docker/model-runner                   latest-diffusers   b7dd30f273fa   10 minutes ago   2.56GB    624.7MB       1.938GB       0

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ilopezluna, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive support for the 'diffusers' backend within the docker model install-runner command. It integrates the new backend into the command-line interface by updating usage instructions and validation rules, and ensures that the appropriate Docker image variant is provisioned when a user opts to install the diffusers backend.

Highlights

  • Diffusers Backend Integration: Added support for the 'diffusers' backend, allowing users to install it via the docker model install-runner --backend diffusers command.
  • CLI Command Updates: The install-runner command's usage message and backend validation logic have been updated to include 'diffusers' as a recognized and supported backend option.
  • Controller Image Selection: Implemented logic to correctly select the 'diffusers' controller image variant when the diffusers backend is specified for installation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/release.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully integrates the diffusers backend, adding necessary imports, updating the command-line usage string, and extending the backend validation logic. The changes are well-contained and directly address the goal of supporting the new backend. One area for improvement is to enhance the maintainability of the backend validation error message by dynamically generating the list of supported backends.

ilopezluna and others added 2 commits January 20, 2026 13:39
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ilopezluna ilopezluna changed the title [WIP] install diffusers Install diffusers Jan 20, 2026
@ilopezluna ilopezluna marked this pull request as ready for review January 20, 2026 15:27
@ilopezluna ilopezluna requested a review from a team January 20, 2026 15:27
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider centralizing the list of supported backends (currently duplicated in backendUsage, validBackends, docs, and controller image variant) into a single source of truth to avoid drift when adding or removing backends in the future.
  • In runInstallOrStart, you might simplify backend validation by using a map[string]struct{} or a shared helper instead of looping over a slice, which would also make it easier to reuse for other commands that need backend validation.
  • For controllerImageVariant, it may be clearer to group backend-specific overrides (vllm, diffusers, etc.) together and explicitly default to llama.cpp, so it’s immediately obvious which backends rely on GPU detection and which have fixed variants.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider centralizing the list of supported backends (currently duplicated in `backendUsage`, `validBackends`, docs, and controller image variant) into a single source of truth to avoid drift when adding or removing backends in the future.
- In `runInstallOrStart`, you might simplify backend validation by using a `map[string]struct{}` or a shared helper instead of looping over a slice, which would also make it easier to reuse for other commands that need backend validation.
- For `controllerImageVariant`, it may be clearer to group backend-specific overrides (vllm, diffusers, etc.) together and explicitly default to llama.cpp, so it’s immediately obvious which backends rely on GPU detection and which have fixed variants.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

# Conflicts:
#	cmd/cli/docs/reference/model_start-runner.md
Copy link
Contributor

@doringeman doringeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also tag & release!

@ilopezluna ilopezluna merged commit 5932a0e into main Jan 23, 2026
15 checks passed
@ilopezluna ilopezluna deleted the install-diffusers branch January 23, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants