-
Notifications
You must be signed in to change notification settings - Fork 86
Install diffusers #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install diffusers #583
Conversation
Summary of ChangesHello @ilopezluna, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive support for the 'diffusers' backend within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully integrates the diffusers backend, adding necessary imports, updating the command-line usage string, and extending the backend validation logic. The changes are well-contained and directly address the goal of supporting the new backend. One area for improvement is to enhance the maintainability of the backend validation error message by dynamically generating the list of supported backends.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
74e760d to
8ba471d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Consider centralizing the list of supported backends (currently duplicated in
backendUsage,validBackends, docs, and controller image variant) into a single source of truth to avoid drift when adding or removing backends in the future. - In
runInstallOrStart, you might simplify backend validation by using amap[string]struct{}or a shared helper instead of looping over a slice, which would also make it easier to reuse for other commands that need backend validation. - For
controllerImageVariant, it may be clearer to group backend-specific overrides (vllm, diffusers, etc.) together and explicitly default to llama.cpp, so it’s immediately obvious which backends rely on GPU detection and which have fixed variants.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider centralizing the list of supported backends (currently duplicated in `backendUsage`, `validBackends`, docs, and controller image variant) into a single source of truth to avoid drift when adding or removing backends in the future.
- In `runInstallOrStart`, you might simplify backend validation by using a `map[string]struct{}` or a shared helper instead of looping over a slice, which would also make it easier to reuse for other commands that need backend validation.
- For `controllerImageVariant`, it may be clearer to group backend-specific overrides (vllm, diffusers, etc.) together and explicitly default to llama.cpp, so it’s immediately obvious which backends rely on GPU detection and which have fixed variants.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
# Conflicts: # cmd/cli/docs/reference/model_start-runner.md
doringeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also tag & release!
Add support to install diffusers backend via
docker model install-runner --backend diffusersThe variant requires 2GB on disk: