DevContainer commands now default the workspace folder to the current directory if not specified. #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathiyarasy
changed the title
chrmarti
requested changes
Dec 1, 2025
Contributor
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
Great, thanks! Left a few comments.
| jsonOutput = JSON.parse(result.stdout.trim()); | ||
| } catch (parseError) { | ||
| // If direct parsing fails, try extracting JSON from mixed output | ||
| const lines = result.stdout.split('\n'); |
Contributor
There was a problem hiding this comment.
This seems to be a bug in the output. Let's not block on this, something to look into in the future.
mr-brobot
suggested changes
Jan 20, 2026
| .options({ | ||
| 'log-level': { choices: ['error' as 'error', 'info' as 'info', 'debug' as 'debug', 'trace' as 'trace'], default: 'error' as 'error', description: 'Log level.' }, | ||
| 'workspace-folder': { type: 'string', description: 'Workspace folder to use for the configuration.', demandOption: true }, | ||
| 'workspace-folder': { type: 'string', description: 'Workspace folder to use for the configuration.If --workspace-folder is not provided, this defaults to the current directory' }, |
There was a problem hiding this comment.
Suggested change
| 'workspace-folder': { type: 'string', description: 'Workspace folder to use for the configuration.If --workspace-folder is not provided, this defaults to the current directory' }, | |
| 'workspace-folder': { type: 'string', description: 'Workspace folder to use for the configuration. If --workspace-folder is not provided, this defaults to the current directory' }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1069
Issue summary:
This PR enhances the user experience by automatically defaulting the [--workspace-folder] parameter to the current working directory when it is not explicitly specified. The following DevContainer CLI commands will now use the current working directory as the default workspace folder if [--workspace-folder] is omitted:
Test cases is implemented for all these commands