Add cmdio test helpers for output capture #4334
Merged
+56
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace direct os.Stderr usage in logdiag with cmdio.RenderDiagnostics. Since cmdio is always initialized before logdiag in production, we can safely use the context-based writer. Also rename cmdio.RenderDiagnosticsToErrorOut to cmdio.RenderDiagnostics (keeping the old name as a deprecated alias for compatibility). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Adds two new test helper functions to reduce boilerplate: - NewTestContextWithStdout: Captures stdout, discards stderr - NewTestContextWithStderr: Captures stderr, discards stdout Migrates existing tests in bundle/render and cmd/pipelines to use the new helpers, reducing test setup from 3 lines to 1 line. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
pietern
requested review from
andrewnester,
anton-107,
denik,
jefferycheng1,
kanterov,
lennartkats-db and
shreyas-goenka
as code owners
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
approved these changes
Jan 20, 2026
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
force-pushed
the
cmdio-testing
branch
from
5e6d2d0 to
5a588a4
Compare
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 5a588a4
24 interesting tests: 19 KNOWN, 4 RECOVERED, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 9a4ca45
29 interesting tests: 19 KNOWN, 4 RECOVERED, 3 FAIL, 2 BUG, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds two new test helper functions to reduce boilerplate:
Migrates existing tests in bundle/render and cmd/pipelines to use the new helpers.
Why
Reduces number of lines required for test setup.