TST: test that clip(x) returns a copy not a view #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a test to verify that clip(x, None, None) returns a copy rather than a view, which aligns with the behavior of NumPy 2.x and CuPy 13.x. The specification doesn't explicitly require this behavior, but the test ensures consistency across wrapped libraries.
Changes:
- Adds a new test
test_clip_nonethat verifiesclipreturns a copy when both min and max are None
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The spec only says that "If both min and max are None, the elements of the returned array must equal the respective elements in x" Bare NumPy 2.x and CuPy 13.x return copes: >>> x = np.arange(8); np.may_share_memory(x, np.clip(x)) False Thus assume that all wrapped libraries should return a copy, too. Add a test to this effect.
ev-br
force-pushed
the
test_clip_none_copy
branch
from
1c3968b to
c1b16c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec only says that "If both min and max are None, the elements of the returned array must equal the respective elements in x"
Bare NumPy 2.x and CuPy 13.x return copes:
Thus assume that all wrapped libraries should return a copy, too. Add a test to this effect.