Remove py < 3.9 deps; Mention dropped python version support in changes #769
+7
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
Also removes the "Modernize project definition" entry. CHANGES.rst should be written for users of the library. The entry had no relevance for end users.
amotl
reviewed
Jan 20, 2026
Comment on lines
51
to
-60
| dependencies = [ | ||
| "importlib-metadata; python_version<'3.8'", | ||
| "orjson", | ||
| "urllib3", | ||
| "verlib2>=0.3.1", | ||
| ] | ||
|
|
||
| [dependency-groups] | ||
| dev = [ | ||
| "backports.zoneinfo<1; python_version<'3.9'", |
Member
There was a problem hiding this comment.
Hi. This would contradict the other patch.
Member
There was a problem hiding this comment.
I feel an urge to leave older Python versions behind, contrary to GH-759, and I don't want to provide stop energy. I have a different stance, but we can elaborate later.
amotl
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes the "Modernize project definition" entry. CHANGES.rst
should be written for users of the library. The entry had no relevance
for end users.