-
Notifications
You must be signed in to change notification settings - Fork 31
Cleanup dev setup #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup dev setup #767
Conversation
This comment was marked as spam.
This comment was marked as spam.
46472e4 to
5dc922f
Compare
033fc19 to
3c60af2
Compare
- Removes buildout; test_layer now fetches the crate package itself - Removes setup.py - Removes stale bin/test - Removes stale requirements.txt - Updates DEVELOP.rst - Removes poethepoet. Most python developers are familiar with `ruff`, `mypy` and `pytest`, no need to add an extra DSL on top that obfuscates what's being used. - Removes `bootstrap.sh`. `python -m venv` or `uv venv` are trivial enough and Python developers should be familiar with them. - Removes the `devtools/create_tag.sh` script. It used `python setup.py --version` to get the new version, which since #757 was broken - running into a chicken and egg problem: Can't read the version from git when about to create a new version tag. Must use `git tag -s <version>` instead. - Updates the release job. It used `python -m build`, which wasn't specified as dependency anywhere. `hatch` is now used which `uv build` will pickup.
3c60af2 to
fa11529
Compare
|
Could a mac user maybe have a look at the failure? Could be something odd with the teardown/port release & re-use. Can't reproduce it on my machine. |
I think it's a fluke so I am just re-running the failed test case on CI, see also #404. |
|
I realized that requirements.txt and bin/test isn't entirely stale. Currently the doc-tests still rely on the zope testrunner. I'm working on migrating that to use pytest too. A project shouldn't need two test runners, and their setup shouldn't be split across pyproject/setup/requirements.txt |
amotl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the excellent cleanup, including the removal of buildout. 💯
| env: | ||
| CRATEDB_VERSION: ${{ matrix.cratedb-version }} | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now that we have been able to define the CrateDB version on the test matrix before, which is no longer possible. Is it possible to bring this back?
pyproject.tomlalreadyruff,mypyandpytest, no need to add an extra DSL on top thatobfuscates what's being used.
bootstrap.sh.python -m venvoruv venvare trivialenough and Python developers should be familiar with them.
devtools/create_tag.shscript. It usedpython setup.py --versionto get the new version, which sinceProject versioning: Use
versioningit#757 was broken - runninginto a chicken and egg problem: Can't read the version from git
when about to create a new version tag. Must use
git tag -s <version>instead.python -m build, which wasn'tspecified as dependency anywhere.
hatchis now used whichuv buildwill pickup.