Skip to content

Conversation

@mfussenegger
Copy link
Member

@mfussenegger mfussenegger commented Jan 19, 2026

  • Removes buildout; test_layer now fetches the crate package itself
  • Removes setup.py; there's a pyproject.toml already
  • Removes stale bin/test
  • Removes stale requirements.txt
  • Updates DEVELOP.rst to reflect the current state - there were several oudated references.
  • Removes poethepoet. Most python developers are familiar with ruff,
    mypy and pytest, no need to add an extra DSL on top that
    obfuscates what's being used.
  • Removes bootstrap.sh. python -m venv or uv venv are trivial
    enough and Python developers should be familiar with them.
  • Removes the devtools/create_tag.sh script. It used python setup.py --version to get the new version, which since
    Project versioning: Use versioningit #757 was broken - running
    into a chicken and egg problem: Can't read the version from git
    when about to create a new version tag. Must use git tag -s <version> instead.
  • Updates the release job, which used python -m build, which wasn't
    specified as dependency anywhere. hatch is now used which uv build
    will pickup.

@coderabbitai

This comment was marked as spam.

@mfussenegger mfussenegger force-pushed the j/dev-setup branch 11 times, most recently from 46472e4 to 5dc922f Compare January 19, 2026 09:17
@mfussenegger mfussenegger force-pushed the j/dev-setup branch 2 times, most recently from 033fc19 to 3c60af2 Compare January 19, 2026 09:30
@mfussenegger mfussenegger marked this pull request as ready for review January 19, 2026 09:32
- Removes buildout; test_layer now fetches the crate package itself
- Removes setup.py
- Removes stale bin/test
- Removes stale requirements.txt
- Updates DEVELOP.rst
- Removes poethepoet. Most python developers are familiar with `ruff`,
  `mypy` and `pytest`, no need to add an extra DSL on top that
  obfuscates what's being used.
- Removes `bootstrap.sh`. `python -m venv` or `uv venv` are trivial
  enough and Python developers should be familiar with them.
- Removes the `devtools/create_tag.sh` script. It used `python setup.py
  --version` to get the new version, which since
  #757 was broken - running
  into a chicken and egg problem: Can't read the version from git
  when about to create a new version tag. Must use `git tag -s
  <version>` instead.
- Updates the release job. It used `python -m build`, which wasn't
  specified as dependency anywhere. `hatch` is now used which `uv build`
  will pickup.
@mfussenegger
Copy link
Member Author

Could a mac user maybe have a look at the failure?

FAILED tests/testing/test_layer.py::LayerTest::test_cluster - IndexError: list index out of range
FAILED tests/testing/test_layer.py::LayerTest::test_default_settings - AssertionError: 'http://127.0.0.1:4201/' != 'http://127.0.0.1:4200/'
- http://127.0.0.1:4201/
?                     ^
+ http://127.0.0.1:4200/
?                     ^
FAILED tests/testing/test_layer.py::LayerTest::test_environment_variables - AssertionError: 1879048192 != 314572800

Could be something odd with the teardown/port release & re-use. Can't reproduce it on my machine.

@amotl
Copy link
Member

amotl commented Jan 19, 2026

Could a mac user maybe have a look at the failure? Could be something odd with the teardown/port release & re-use. Can't reproduce it on my machine.

I think it's a fluke so I am just re-running the failed test case on CI, see also #404.

@mfussenegger
Copy link
Member Author

I realized that requirements.txt and bin/test isn't entirely stale. Currently the doc-tests still rely on the zope testrunner.

I'm working on migrating that to use pytest too. A project shouldn't need two test runners, and their setup shouldn't be split across pyproject/setup/requirements.txt

Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the excellent cleanup, including the removal of buildout. 💯

@mfussenegger mfussenegger merged commit 65d3795 into main Jan 19, 2026
22 of 23 checks passed
@mfussenegger mfussenegger deleted the j/dev-setup branch January 19, 2026 14:55
mfussenegger added a commit that referenced this pull request Jan 19, 2026
mfussenegger added a commit that referenced this pull request Jan 19, 2026
mfussenegger added a commit that referenced this pull request Jan 19, 2026
mfussenegger added a commit that referenced this pull request Jan 19, 2026
Comment on lines 40 to 41
env:
CRATEDB_VERSION: ${{ matrix.cratedb-version }}
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
Copy link
Member

@amotl amotl Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now that we have been able to define the CrateDB version on the test matrix before, which is no longer possible. Is it possible to bring this back?

mfussenegger added a commit that referenced this pull request Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants