Skip to content

test: remove temp variable and extract fixtures to shorten tests #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bearomorphism merged 1 commit into from
Jan 19, 2026
Merged

test: remove temp variable and extract fixtures to shorten tests #1809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions tests/commands/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,23 @@
import os
from pathlib import Path

import pytest
from pytest_mock import MockerFixture
from pytest_mock import MockerFixture, MockType

from commitizen import defaults
from commitizen.config import BaseConfig
from commitizen.config.json_config import JsonConfig


@pytest.fixture()
def config():
@pytest.fixture
def config() -> BaseConfig:
_config = BaseConfig()
_config.settings.update({"name": defaults.DEFAULT_SETTINGS["name"]})
return _config


@pytest.fixture()
def config_customize():
@pytest.fixture
def config_customize() -> JsonConfig:
json_string = r"""{
"commitizen": {
"name": "cz_customize",
Expand All @@ -41,20 +42,19 @@ def config_customize():
}
}
}"""
_config = JsonConfig(data=json_string, path="not_exist.json")
return _config
return JsonConfig(data=json_string, path=Path("not_exist.json"))


@pytest.fixture()
@pytest.fixture
def changelog_path() -> str:
return os.path.join(os.getcwd(), "CHANGELOG.md")


@pytest.fixture()
@pytest.fixture
def config_path() -> str:
return os.path.join(os.getcwd(), "pyproject.toml")


@pytest.fixture()
def success_mock(mocker: MockerFixture):
@pytest.fixture
def success_mock(mocker: MockerFixture) -> MockType:
return mocker.patch("commitizen.out.success")
Loading