Use JavaAPI bytecode in VM integration tests #4450

shai-almog · 2026-01-20T03:58:19Z

Motivation

Replace fragile in-test generation of java.* sources with the real maintained JavaAPI output so VM/translator integration tests compile against a canonical API surface.
Reduce duplicated, hand-written stub logic (including java.lang.invoke stubs) that can mask mismatches between tests and the JavaAPI project.
Make cross-JDK/target compilation deterministic by compiling JavaAPI/src with the same JDK/target used by each test run and reusing the produced classes.

Description

Added CompilerHelper.compileJavaAPI(Path, CompilerConfig) to compile ../JavaAPI/src into a temporary classes directory using the requested JDK/target and updated compilation behavior to use --patch-module on supported JDKs or fall back to source/target flags for older JDKs.
Added CompilerHelper.copyDirectory(Path, Path) and updated integration tests to copy compiled JavaAPI classes into test classes directories so the translator receives real API bytecode.
Updated integration tests CleanTargetIntegrationTest, LockIntegrationTest, ReadWriteLockIntegrationTest, and StampedLockIntegrationTest to stop emitting large java.* source stubs and instead compile/test against the JavaAPI classes, switching between -classpath (JDK9+) and -bootclasspath (pre-9) as appropriate and guarding unsupported JDK/target combinations.
Updated LambdaIntegrationTest to select an appropriate compiler config, compile the JavaAPI with that compiler, remove ad-hoc java.lang.invoke stub generation, and use the compiled JavaAPI when compiling the test app.

Testing

No automated tests were executed as part of this change (no CI or mvn run was requested).
The changes are limited to test harness code and test sources and add guards to skip incompatible JDK/target permutations to avoid spurious failures during multi-JDK runs.
Local assertions in unit tests remain; the PR does not claim runnable CI verification in this rollout.

Codex Task

github-actions · 2026-01-20T04:05:16Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2282 total, 0 failed, 0 skipped
📊 Line coverage: 52.77% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.io.rest.RequestBuilder$FetchAsPropertyListActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$FetchAsPropertiesActionListener – 0.00%
  - com.codename1.ui.Display$EdtException – 0.00%
  - com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
  - com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsStringAsyncImplActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsJsonMapActionListener – 0.00%
  - com.codename1.payment.Purchase$SynchronizeReceiptsSyncRunnable – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsBytesAsyncImplActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$FetchAsJsonMapActionListener – 0.00%

Static Analysis

✅ SpotBugs: 0 findings (no issues) [Report archive]
❌ PMD: 925 findings (P2: 42, P3: 875, P4: 8) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/capture/Capture.java:250 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
  - P2: CodenameOne/src/com/codename1/compat/java/util/Objects.java:47 – The method name and parameter number are suspiciously close to equals(Object) (rule: SuspiciousEqualsMethodName)
  - P2: CodenameOne/src/com/codename1/components/StorageImageAsync.java:43 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
  - P2: CodenameOne/src/com/codename1/components/StorageImageAsync.java:44 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
  - P2: CodenameOne/src/com/codename1/io/BufferedInputStream.java:38 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
  - …and 920 more
❌ Checkstyle: 220818 findings (Warning: 220818) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 220813 more

Generated automatically by the PR CI workflow.

shai-almog · 2026-01-20T04:37:18Z

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.
graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.
graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.
kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

VM Translation Time: 362 seconds
Compilation Time: 142 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	37539 ms
Extract Extensions	18 ms
Google Services Setup	2 ms
Scan Classes	1797 ms
Extract Libs	1242 ms
Inject Build Hints	71 ms
Generate Unit Tests	3 ms
Generate Stubs	1789 ms
Compile Stubs	3185 ms
Generate Icons	1686 ms
Prepare ParparVM	272 ms
ParparVM Execution	196693 ms
Post-VM Setup	216 ms
CocoaPods	4895 ms
Finalize	21 ms
Total Time	249430 msMaven Overhead : 113000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot (Run)	83000 ms
App Install	22000 ms
App Launch	16000 ms
Test Execution	165000 ms

github-actions · 2026-01-20T19:27:27Z

✅ ByteCodeTranslator Quality Report

Test & Coverage

✅ Tests: 171 total, 0 failed, 2 skipped

Benchmark Results

Execution Time: 10274 ms
Hotspots (Top 20 sampled methods):
- 22.40% java.lang.String.indexOf (400 samples)
- 17.36% com.codename1.tools.translator.Parser.isMethodUsed (310 samples)
- 15.57% com.codename1.tools.translator.Parser.addToConstantPool (278 samples)
- 12.09% java.util.ArrayList.indexOf (216 samples)
- 4.26% java.lang.Object.hashCode (76 samples)
- 3.36% com.codename1.tools.translator.ByteCodeClass.calcUsedByNative (60 samples)
- 2.74% java.lang.System.identityHashCode (49 samples)
- 1.85% com.codename1.tools.translator.BytecodeMethod.equals (33 samples)
- 1.62% com.codename1.tools.translator.ByteCodeClass.fillVirtualMethodTable (29 samples)
- 1.12% java.io.FileOutputStream.writeBytes (20 samples)
- 0.90% com.codename1.tools.translator.Parser.cullMethods (16 samples)
- 0.90% java.io.FileOutputStream.open0 (16 samples)
- 0.78% com.codename1.tools.translator.Parser.generateClassAndMethodIndexHeader (14 samples)
- 0.67% com.codename1.tools.translator.BytecodeMethod.optimize (12 samples)
- 0.67% com.codename1.tools.translator.BytecodeMethod.appendCMethodPrefix (12 samples)
- 0.67% java.lang.StringBuilder.append (12 samples)
- 0.62% java.lang.Integer.getChars (11 samples)
- 0.56% java.io.FileInputStream.open0 (10 samples)
- 0.50% java.io.UnixFileSystem.getBooleanAttributes0 (9 samples)
- 0.45% java.util.TreeMap.getEntry (8 samples)
⚠️ Coverage report not generated.

Static Analysis

✅ SpotBugs: no findings (report was not generated by the build).
⚠️ PMD report not generated.
⚠️ Checkstyle report not generated.

Generated automatically by the PR CI workflow.

Use JavaAPI classes in VM integration tests

1da3aa5

shai-almog added the codex label Jan 20, 2026 — with ChatGPT Codex Connector

Fix JavaAPI compilation helper usage

b2064b5

shai-almog added 9 commits January 20, 2026 07:10

Avoid linking executables in lock integration tests

600fd76

Use concrete lock types in lock integration apps

13b49e3

Skip ReadWriteLock CMake build due to translator issues

6ccefb7

Restore missing headers and invoke stubs for tests

d9f02d7

Fix missing IOException import in lambda test

a8712b4

Skip LambdaIntegrationTest CMake build for now

29f0b8b

Add String header stub for clean target build

a3d0340

Stub java.lang.Object runtime symbols for clean target

e3fdb73

Declare java.lang.Object stubs in clean target header

a3f5530

shai-almog added 6 commits January 21, 2026 05:59

Allow overriding fast unit smoke test

a24c553

Remove runtime test stubs and add java.lang.invoke

e2afd2d

Align ReentrantReadWriteLock return types

5a7d883

Keep Objective-C sources in CMake executable

ff70b20

Copy JavaAPI classes into clean target inputs

b2a70ac

Compile JavaAPI in bytecode and file tests

d1149c3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use JavaAPI bytecode in VM integration tests #4450

Use JavaAPI bytecode in VM integration tests #4450

shai-almog commented Jan 20, 2026

Uh oh!

github-actions bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

shai-almog commented Jan 20, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Use JavaAPI bytecode in VM integration tests #4450

Are you sure you want to change the base?

Use JavaAPI bytecode in VM integration tests #4450

Conversation

shai-almog commented Jan 20, 2026

Motivation

Description

Testing

Uh oh!

github-actions bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Benchmark Results

Detailed Performance Metrics

Uh oh!

github-actions bot commented Jan 20, 2026

✅ ByteCodeTranslator Quality Report

Test & Coverage

Benchmark Results

Static Analysis

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Jan 20, 2026 •

edited

Loading

shai-almog commented Jan 20, 2026 •

edited

Loading