Skip to content

Conversation

@tobixlea
Copy link
Contributor

@tobixlea tobixlea commented Jan 5, 2026

Issue #, if available:

Description of changes:

  • Add aws-serverless-java-container-springboot4 module with Spring Framework 7.x support
  • Add aws-serverless-springboot4-archetype for project generation
  • Add 4 working Spring Boot 4.0 samples:
    • Basic pet-store: compatible and tested with java25 runtime
    • alt-pet-store: compatible and tested with java25 runtime
    • graphql-pet-store: compatible and tested with java25 runtime
    • pet-store-native: compatible and tested with java25 runtime
  • All samples tested and deployed successfully to AWS Lambda
  • Full compatibility with Jakarta EE 11 and Java 21 runtime
  • Update root pom.xml to include new modules"

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

Copy link
Contributor

@bnusunny bnusunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Please check the two comments I left.

@tobixlea tobixlea force-pushed the sjc-spring-boot-update branch 26 times, most recently from d7dd038 to 52fedb7 Compare January 16, 2026 21:52
@tobixlea tobixlea force-pushed the sjc-spring-boot-update branch 2 times, most recently from 80b787b to a5a34b5 Compare January 16, 2026 23:08
@tobixlea tobixlea force-pushed the sjc-spring-boot-update branch from a5a34b5 to b83323f Compare January 16, 2026 23:24
@tobixlea tobixlea requested a review from bnusunny January 20, 2026 18:22
<dependency>
<groupId>com.amazonaws.serverless</groupId>
<artifactId>aws-serverless-java-container-core</artifactId>
<version>${project.version}</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how this worked, but if it was this sort of variable ${project.version} we might want to keep it like that, so it's easier in the future to update? (unless there's a reason to not do it, and it should be mentioned in the PR description)

(same in other pom.xml files).

| Version | Branch | Java Enterprise support | Spring versions | JAX-RS/ Jersey version | Struts support | Spark support |
|---------|--------|-----------------------------|-----------------|------------------------|----------------|---------------|
| 1.x | [1.x](https://github.com/aws/serverless-java-container/tree/1.x) | Java EE (javax.*) | 5.x (Boot 2.x) | 2.x | :white_check_mark: | :white_check_mark: |
| 2.x | [main](https://github.com/aws/serverless-java-container/tree/main) | Jakarta EE 9-10 (jakarta.*) | 6.x (Boot 3.x) | 3.x | :x: | :x: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to create a "2.x" branch from the current main branch for SpringBoot3 support. And update the branch name here.

Follow the quick start guides in [our wiki](https://github.com/aws/serverless-java-container/wiki) to integrate Serverless Java Container with your project:
* [Spring quick start](https://github.com/aws/serverless-java-container/wiki/Quick-start---Spring)
* [Spring Boot 2 quick start](https://github.com/aws/serverless-java-container/wiki/Quick-start---Spring-Boot2)
* [Spring Boot 3 quick start](https://github.com/aws/serverless-java-container/wiki/Quick-start---Spring-Boot3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a Spring Boot 4 quick start

<artifactId>aws-serverless-java-container</artifactId>
<groupId>com.amazonaws.serverless</groupId>
<version>2.1.5-SNAPSHOT</version>
<version>2.1.3</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest 2.x version is 2.1.5. We should use the latest 2.x version here.

<groupId>com.amazonaws.serverless</groupId>
<artifactId>aws-serverless-java-container-core</artifactId>
<version>2.1.5-SNAPSHOT</version>
<version>2.1.3</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 2.1.5

<groupId>com.amazonaws.serverless</groupId>
<artifactId>aws-serverless-java-container-core</artifactId>
<version>2.1.5-SNAPSHOT</version>
<version>2.1.3</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 2.1.5 too

<groupId>com.amazonaws.serverless</groupId>
<artifactId>aws-serverless-java-container</artifactId>
<version>2.1.5-SNAPSHOT</version>
<version>2.1.3</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 2.1.5

<groupId>com.amazonaws.serverless.archetypes</groupId>
<artifactId>aws-serverless-springboot3-archetype</artifactId>
<version>2.1.5-SNAPSHOT</version>
<version>2.1.3</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 2.1.5

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README said this sample is for x86 architecture. We should not change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants