fix(typing): resolve ty diagnostics in logging and metrics modules #7953
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
- logging/buffer/functions.py: add guard clause for None values from dict.get() before comparison - metrics/base.py: add cast for functools.wraps union type, add set_default_dimensions stub to base class Resolves 3 of 10 diagnostics from #7929
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7953 +/- ##
========================================
Coverage 96.72% 96.72%
========================================
Files 278 278
Lines 13627 13630 +3
Branches 1083 1084 +1
========================================
+ Hits 13181 13184 +3
Misses 327 327
Partials 119 119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ConnorKirk
force-pushed
the
maintenance/ty-diagnostics-7902
branch
from
5b5b7bb to
e00a25e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: closes #7929 (partial)
Summary
Resolves 3 of 10 ty diagnostics to expand type checking coverage.
Changes
logging/buffer/functions.py (1 diagnostic fixed)
Nonevalues fromdict.get()before comparison<operator doesn't supportint | Noneoperandsmetrics/base.py (2 diagnostics fixed)
castforfunctools.wrapsto handle union callable typeset_default_dimensionsstub method toMetricManagerbase classUser experience
No user-facing changes. This is an internal typing improvement that enables stricter type checking with the ty type checker.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.