Skip to content

fix session cpp node-supplier #17039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hongzhi-gao wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix session cpp node-supplier #17039

hongzhi-gao wants to merge 4 commits into from

Conversation

@hongzhi-gao
Copy link
Contributor

@hongzhi-gao hongzhi-gao commented Jan 19, 2026

Description

  1. Use "SHOW AVAILABLE URLS" instead of "SHOW DATANODES"
  2. The builder of the newly added SessionBuilder will detect the issue of setting both nodeUrls and host:port simultaneously.

Content1 ...

Content2 ...

Content3 ...

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.
Key changed/added classes (or packages if there are too many classes) in this PR

jt2594838
jt2594838 approved these changes Jan 20, 2026
View reviewed changes
iotdb-client/client-cpp/src/main/SessionBuilder.h Outdated
if (!AbstractSessionBuilder::nodeUrls.empty() &&
(AbstractSessionBuilder::host != DEFAULT_HOST ||
AbstractSessionBuilder::rpcPort != DEFAULT_RPC_PORT)) {
throw IoTDBException("Session builder does not support node urls");
Copy link
Contributor

@jt2594838 jt2594838 Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exception message is not precise, maybe:
Session builder does not support setting node urls and host/rpcPort at the same time.

@hongzhi-gao
fix session exception
c466f95
@hongzhi-gao
Merge branch 'fix/session-cpp-node-supplier' of github.com:761417898/…
6d262b2 
…iotdb into fix/session-cpp-node-supplier

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jt2594838 jt2594838 jt2594838 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hongzhi-gao @jt2594838