Skip to content

HBASE-29844 Upgrade hbase-metrics to use junit5 #7654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
taklwu merged 1 commit into from
Jan 22, 2026
Merged

HBASE-29844 Upgrade hbase-metrics to use junit5 #7654

taklwu merged 1 commit into from
Jan 22, 2026
+63 −128

Conversation

@liuxiaocs7
Copy link
Contributor

@liuxiaocs7 liuxiaocs7 commented Jan 21, 2026 •
edited
Loading

@liuxiaocs7 liuxiaocs7 changed the title HBASE-29844: Upgrade hbase-metrics to use junit5 HBASE-29844 Upgrade hbase-metrics to use junit5 Jan 21, 2026
@Apache-HBase
Copy link

Apache-HBase commented Jan 21, 2026

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 28s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 50s master passed
+1 💚 compile 0m 15s master passed
+1 💚 javadoc 0m 16s master passed
+1 💚 shadedjars 6m 6s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 15s the patch passed
+1 💚 compile 0m 12s the patch passed
+1 💚 javac 0m 12s the patch passed
+1 💚 javadoc 0m 13s the patch passed
+1 💚 shadedjars 7m 6s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 36s hbase-metrics in the patch passed.
23m 25s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7654
JIRA Issue HBASE-29844
Optional Tests javac javadoc unit shadedjars compile
uname Linux ac90a11c818e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / dc9cbd2
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/1/testReport/
Max. process+thread count 212 (vs. ulimit of 30000)
modules C: hbase-metrics U: hbase-metrics
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jan 21, 2026

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 3m 59s master passed
+1 💚 compile 0m 22s master passed
+1 💚 checkstyle 0m 14s master passed
+1 💚 spotbugs 0m 28s master passed
+1 💚 spotless 1m 3s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 0s the patch passed
+1 💚 compile 0m 16s the patch passed
+1 💚 javac 0m 16s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 8s the patch passed
+1 💚 xmllint 0m 1s No new issues.
+1 💚 spotbugs 0m 24s the patch passed
+1 💚 hadoopcheck 11m 22s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 spotless 0m 44s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
30m 19s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7654
JIRA Issue HBASE-29844
Optional Tests dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti
uname Linux ad6cf714ac78 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / dc9cbd2
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-metrics U: hbase-metrics
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jan 21, 2026

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 2m 35s master passed
+1 💚 compile 0m 14s master passed
+1 💚 checkstyle 0m 7s master passed
+1 💚 spotbugs 0m 15s master passed
+1 💚 spotless 0m 39s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 15s the patch passed
+1 💚 compile 0m 12s the patch passed
+1 💚 javac 0m 12s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 5s the patch passed
+1 💚 xmllint 0m 0s No new issues.
+1 💚 spotbugs 0m 19s the patch passed
+1 💚 hadoopcheck 8m 29s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 spotless 0m 33s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 8s The patch does not generate ASF License warnings.
22m 42s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7654
Optional Tests dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti
uname Linux 149219ec5cb6 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f430c54
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-metrics U: hbase-metrics
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jan 21, 2026

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 44s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 13s master passed
+1 💚 compile 0m 20s master passed
+1 💚 javadoc 0m 17s master passed
+1 💚 shadedjars 8m 36s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 20s the patch passed
+1 💚 compile 0m 15s the patch passed
+1 💚 javac 0m 15s the patch passed
+1 💚 javadoc 0m 13s the patch passed
+1 💚 shadedjars 7m 25s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 38s hbase-metrics in the patch passed.
29m 27s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7654
Optional Tests javac javadoc unit shadedjars compile
uname Linux d1e1a5a10336 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f430c54
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/2/testReport/
Max. process+thread count 203 (vs. ulimit of 30000)
modules C: hbase-metrics U: hbase-metrics
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

taklwu
taklwu approved these changes Jan 22, 2026
View reviewed changes
Copy link
Contributor

@taklwu taklwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you plan to upgrade more modules to junit5 and link them to HBASE-23671 ?

@taklwu taklwu merged commit a13d7f2 into apache:master Jan 22, 2026
2 checks passed
liuxiaocs7 added a commit to liuxiaocs7/hbase that referenced this pull request Jan 22, 2026
@liuxiaocs7
HBASE-29844 Upgrade hbase-metrics to use junit5 (apache#7654)
67adeff 
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
liuxiaocs7 added a commit to liuxiaocs7/hbase that referenced this pull request Jan 22, 2026
@liuxiaocs7
HBASE-29844 Upgrade hbase-metrics to use junit5 (apache#7654)
eab7e95 
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
@liuxiaocs7
Copy link
Contributor Author

liuxiaocs7 commented Jan 22, 2026

do you plan to upgrade more modules to junit5 and link them to HBASE-23671 ?

Hi, @taklwu, sure, I’ll continue working on it.

This was referenced Jan 22, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taklwu taklwu taklwu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liuxiaocs7 @Apache-HBase @taklwu