Skip to content

Conversation

@gavinchou
Copy link
Contributor

There are some object storage providers, e.g. TOS by ByteDance Cloud (Volcano Engine), is not fully compatible with AWS S3 API, the HTTP response code is 200(AWS) vs 404(TOS) when list non-existing objects, which leads to unexpected exception thrown by S3 SDK.

There are some object storage providers, e.g. TOS by  ByteDance Cloud
(Volcano Engine), is not fully compatible with AWS S3 API, the HTTP
response code is 200(AWS) vs 404(TOS) when list non-existing objects,
which leads to unexpected exception thrown by S3 SDK.
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 11.11% (1/9) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.32% (1787/2253)
Line Coverage 64.75% (31817/49138)
Region Coverage 65.45% (15851/24218)
Branch Coverage 56.05% (8427/15034)

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.46% (19117/36441)
Line Coverage 35.82% (177547/495677)
Region Coverage 32.28% (137200/425021)
Branch Coverage 33.23% (59418/178815)

@gavinchou
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 30916 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d1faf66ae1e10dbebc2a4a2f726e2feea3413d82, data reload: false

------ Round 1 ----------------------------------
q1	17617	4720	4577	4577
q2	2044	322	199	199
q3	10205	1302	744	744
q4	10219	830	316	316
q5	7513	2097	1885	1885
q6	186	167	140	140
q7	877	710	587	587
q8	9269	1342	1049	1049
q9	4956	4627	4603	4603
q10	6745	1649	1276	1276
q11	511	295	276	276
q12	343	382	221	221
q13	17785	3815	3090	3090
q14	230	241	211	211
q15	595	532	524	524
q16	651	631	564	564
q17	635	794	497	497
q18	6754	6552	6470	6470
q19	1017	989	630	630
q20	404	345	238	238
q21	2719	2170	1875	1875
q22	1029	1011	944	944
Total cold run time: 102304 ms
Total hot run time: 30916 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4734	4717	4715	4715
q2	303	413	313	313
q3	2174	2657	2248	2248
q4	1347	1777	1261	1261
q5	4034	3991	4016	3991
q6	210	172	134	134
q7	1936	1854	1716	1716
q8	2797	2510	2512	2510
q9	7241	7171	7201	7171
q10	2699	2800	2346	2346
q11	547	474	467	467
q12	728	766	650	650
q13	3594	4066	3295	3295
q14	282	319	300	300
q15	576	538	520	520
q16	647	715	660	660
q17	1180	1382	1444	1382
q18	8101	7972	7821	7821
q19	944	868	858	858
q20	1994	2087	1938	1938
q21	4696	4399	4471	4399
q22	1138	1054	1005	1005
Total cold run time: 51902 ms
Total hot run time: 49700 ms

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 11.11% (1/9) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.32% (1787/2253)
Line Coverage 64.73% (31807/49138)
Region Coverage 65.46% (15854/24218)
Branch Coverage 55.99% (8418/15034)

@doris-robot
Copy link

TPC-DS: Total hot run time: 172655 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d1faf66ae1e10dbebc2a4a2f726e2feea3413d82, data reload: false

query5	4398	653	502	502
query6	331	225	197	197
query7	4210	460	259	259
query8	337	251	235	235
query9	8702	2850	2880	2850
query10	456	328	304	304
query11	15128	15140	14849	14849
query12	181	119	117	117
query13	1252	455	387	387
query14	6266	3069	2833	2833
query14_1	2720	2660	2753	2660
query15	196	192	178	178
query16	984	418	523	418
query17	1096	685	580	580
query18	2513	435	334	334
query19	205	183	154	154
query20	125	120	127	120
query21	215	139	122	122
query22	4138	4218	4145	4145
query23	15961	15577	15159	15159
query23_1	15561	15425	15434	15425
query24	7132	1549	1202	1202
query24_1	1183	1174	1193	1174
query25	553	459	412	412
query26	1244	262	151	151
query27	2773	435	280	280
query28	4575	2160	2169	2160
query29	772	548	459	459
query30	316	243	207	207
query31	818	638	555	555
query32	88	76	72	72
query33	540	359	333	333
query34	920	904	539	539
query35	759	760	678	678
query36	886	902	822	822
query37	150	107	91	91
query38	2721	2711	2640	2640
query39	782	750	728	728
query39_1	710	717	724	717
query40	229	139	128	128
query41	76	72	67	67
query42	97	95	94	94
query43	433	452	420	420
query44	1360	767	759	759
query45	192	193	215	193
query46	861	958	594	594
query47	1440	1476	1274	1274
query48	329	330	248	248
query49	606	431	339	339
query50	694	280	224	224
query51	3828	3843	3726	3726
query52	89	93	81	81
query53	212	233	173	173
query54	277	263	243	243
query55	86	77	79	77
query56	301	303	308	303
query57	1014	1010	925	925
query58	271	268	259	259
query59	2098	2065	1970	1970
query60	321	331	322	322
query61	151	148	147	147
query62	388	366	311	311
query63	197	166	159	159
query64	4829	1192	848	848
query65	3818	3753	3750	3750
query66	1445	423	319	319
query67	15585	15496	15400	15400
query68	2462	1070	728	728
query69	407	313	284	284
query70	1006	948	953	948
query71	306	290	274	274
query72	5273	3162	3248	3162
query73	600	754	310	310
query74	8728	8698	8517	8517
query75	2245	2328	1895	1895
query76	2277	1067	667	667
query77	365	394	302	302
query78	9733	9872	9115	9115
query79	1078	916	590	590
query80	1331	524	454	454
query81	556	273	233	233
query82	1020	152	117	117
query83	337	268	254	254
query84	252	122	99	99
query85	883	489	423	423
query86	412	300	286	286
query87	2930	2879	2748	2748
query88	3527	2596	2580	2580
query89	318	268	240	240
query90	1980	176	172	172
query91	169	157	132	132
query92	78	78	69	69
query93	1147	1000	642	642
query94	655	332	295	295
query95	585	412	316	316
query96	648	518	232	232
query97	2377	2381	2298	2298
query98	211	198	203	198
query99	578	569	513	513
Total cold run time: 246459 ms
Total hot run time: 172655 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 26.65 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d1faf66ae1e10dbebc2a4a2f726e2feea3413d82, data reload: false

query1	0.06	0.05	0.05
query2	0.11	0.06	0.04
query3	0.26	0.08	0.08
query4	1.61	0.12	0.11
query5	0.29	0.25	0.25
query6	1.16	0.66	0.65
query7	0.03	0.03	0.02
query8	0.05	0.04	0.04
query9	0.59	0.50	0.49
query10	0.54	0.53	0.54
query11	0.14	0.10	0.09
query12	0.14	0.10	0.10
query13	0.60	0.57	0.59
query14	0.95	0.94	0.95
query15	0.79	0.78	0.77
query16	0.38	0.39	0.40
query17	1.09	1.02	1.02
query18	0.23	0.22	0.21
query19	1.86	1.78	1.88
query20	0.02	0.02	0.01
query21	15.44	0.25	0.14
query22	6.34	0.06	0.04
query23	15.95	0.29	0.10
query24	0.93	0.27	0.34
query25	0.07	0.09	0.09
query26	0.14	0.13	0.13
query27	0.08	0.04	0.06
query28	3.40	1.09	0.88
query29	12.52	3.92	3.13
query30	0.29	0.13	0.12
query31	2.83	0.63	0.39
query32	3.25	0.55	0.47
query33	2.97	3.04	3.07
query34	16.44	5.03	4.43
query35	4.48	4.39	4.44
query36	0.65	0.51	0.49
query37	0.11	0.06	0.06
query38	0.08	0.05	0.03
query39	0.05	0.03	0.04
query40	0.16	0.14	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 97.26 s
Total hot run time: 26.65 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.46% (19117/36441)
Line Coverage 35.83% (177599/495677)
Region Coverage 32.30% (137267/425021)
Branch Coverage 33.24% (59440/178815)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.46% (25525/35720)
Line Coverage 54.04% (267591/495145)
Region Coverage 51.38% (220701/429534)
Branch Coverage 52.95% (95094/179586)

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 57.14% (4/7) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.45% (25522/35720)
Line Coverage 54.04% (267561/495145)
Region Coverage 51.36% (220597/429534)
Branch Coverage 52.95% (95093/179586)

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 57.14% (4/7) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 24, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.x dev/4.0.x reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants