-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](s3) Treat no such key as empty response when listing objects #60195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[fix](s3) Treat no such key as empty response when listing objects #60195
Conversation
There are some object storage providers, e.g. TOS by ByteDance Cloud (Volcano Engine), is not fully compatible with AWS S3 API, the HTTP response code is 200(AWS) vs 404(TOS) when list non-existing objects, which leads to unexpected exception thrown by S3 SDK.
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 30916 ms |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-DS: Total hot run time: 172655 ms |
ClickBench: Total hot run time: 26.65 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
There are some object storage providers, e.g. TOS by ByteDance Cloud (Volcano Engine), is not fully compatible with AWS S3 API, the HTTP response code is 200(AWS) vs 404(TOS) when list non-existing objects, which leads to unexpected exception thrown by S3 SDK.