[Feature](function) support function array_combinations #60192

daju233 · 2026-01-23T11:21:50Z

What problem does this PR solve?

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2026-01-23T11:21:55Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

zclllyybb · 2026-01-23T19:20:28Z

be/src/vec/functions/array/function_array_combinations.cpp

+        return comb;
+    }
+
+    bool _next_combination(std::vector<size_t>& comb, Int64 k) const {


what's the meaning of I, j, k? dont use those meaningless identifier

zclllyybb · 2026-01-23T19:21:27Z

be/src/vec/functions/array/function_array_combinations.cpp

+
+    Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+                        uint32_t result, size_t input_rows_count) const override {
+        auto left = block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();


dont directly use convert_to_full_column_if_const, but vector_const...

zclllyybb · 2026-01-23T19:21:41Z

be/src/vec/functions/array/function_array_combinations.cpp

+    Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+                        uint32_t result, size_t input_rows_count) const override {
+        auto left = block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+        auto* src_arr = assert_cast<ColumnArray*>(remove_nullable(left)->assume_mutable().get());


why need assume_mutable here?

zclllyybb · 2026-01-23T19:22:46Z

...main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ArrayCombinations.java

+                "array_combinations first argument must be Array");
+        DataType itemType = ((ArrayType) arg0Type).getItemType();
+        return FunctionSignature.ret(ArrayType.of(ArrayType.of(itemType)))
+            .args(getArgument(0).getDataType(), getArgument(1).getDataType());


what if arg1 is not number?

zclllyybb · 2026-01-23T19:23:22Z

regression-test/suites/query_p0/sql_functions/array_functions/array_combinations.groovy

+    sql """ INSERT INTO t_array_combinations VALUES(1, ['foo','bar','baz'], [1,2,3], [1,2,2], [[1,1],[4,5],[1,4]]) """
+
+    qt_test """
+    select k1, array_combinations(s1, 2), array_combinations(a1, 2), array_combinations(a2, 2), array_combinations(aa1,  2) from t_array_combinations order by k1;


there's too few testcases. should add more to cover situations

zclllyybb · 2026-01-23T19:28:36Z

be/src/vec/functions/array/function_array_combinations.cpp

+
+    ColumnPtr _execute_combination(const ColumnArray* nested, size_t input_rows_count,
+                                   const ColumnArray::ColumnOffsets& offsets, Int64 k) const {
+        const auto& data_col = nested->get_data();


re-consider all your var names

zclllyybb · 2026-01-23T19:30:26Z

be/src/vec/functions/array/function_array_combinations.cpp

+
+            std::vector comb = _first_combination(k, row_len);
+
+            for (int i = 0; i < static_cast<size_t>(k); ++i) {


why put a single same for-loop outside the while-loop? maybe you need a do-while?

zclllyybb · 2026-01-23T19:31:03Z

be/src/vec/functions/array/function_array_combinations.cpp

+            size_t curr_off = in_offs[row];
+            size_t row_len = curr_off - prev_off;
+
+            if (k <= 0 || static_cast<size_t>(k) > row_len) {


add reg case and make sure this behaviour is same with target system

zclllyybb · 2026-01-23T19:36:37Z

be/src/vec/functions/array/function_array_combinations.cpp

+            for (int i = 0; i < static_cast<size_t>(k); ++i) {
+                size_t idx = prev_off + comb[i];
+                data_col.get(idx, element);
+                inner->get_data().insert(element);


directly use insert_from could get rid of Field?

zclllyybb · 2026-01-23T19:37:07Z

be/src/vec/functions/array/function_array_combinations.cpp

+
+    ColumnPtr _execute_combination(const ColumnArray* nested, size_t input_rows_count,
+                                   const ColumnArray::ColumnOffsets& offsets, Int64 k) const {
+        const auto& data_col = nested->get_data();


you can reserve for result column

daju233 requested a review from zclllyybb as a code owner January 23, 2026 11:21

daju233 force-pushed the dev-daju233 branch 2 times, most recently from 866f02d to 8317b21 Compare January 23, 2026 11:46

[Feature](function) support function array_combinations

f9ff468

daju233 force-pushed the dev-daju233 branch from 8317b21 to f9ff468 Compare January 23, 2026 11:50

zclllyybb self-assigned this Jan 23, 2026

zclllyybb reviewed Jan 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature](function) support function array_combinations #60192

[Feature](function) support function array_combinations #60192

daju233 commented Jan 23, 2026

Uh oh!

hello-stephen commented Jan 23, 2026

Uh oh!

zclllyybb Jan 23, 2026

Uh oh!

zclllyybb Jan 23, 2026

Uh oh!

zclllyybb Jan 23, 2026

Uh oh!

zclllyybb Jan 23, 2026

Uh oh!

zclllyybb Jan 23, 2026

Uh oh!

zclllyybb Jan 23, 2026

Uh oh!

zclllyybb Jan 23, 2026

Uh oh!

zclllyybb Jan 23, 2026

Uh oh!

zclllyybb Jan 23, 2026

Uh oh!

zclllyybb Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		std::vector comb = _first_combination(k, row_len);

		for (int i = 0; i < static_cast<size_t>(k); ++i) {

[Feature](function) support function array_combinations #60192

Are you sure you want to change the base?

[Feature](function) support function array_combinations #60192

Conversation

daju233 commented Jan 23, 2026

What problem does this PR solve?

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Jan 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants