-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Opt](warmup) Limit the download rate of warmup task #60180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
be/src/cloud/config.cpp
Outdated
|
|
||
| // Rate limit for warmup download in bytes per second, default 100MB/s | ||
| // 0 means no limit | ||
| DEFINE_mInt64(warmup_download_rate_limit_bytes_per_second, "104857600"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest naming file_cache_warmup_download_rate_limit_bytes_per_second
be/src/runtime/exec_env_init.cpp
Outdated
| _index_policy_mgr = new IndexPolicyMgr(); | ||
|
|
||
| // Initialize warmup download rate limiter for cloud mode | ||
| if (config::is_cloud_mode() && config::warmup_download_rate_limit_bytes_per_second > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better dynamically configurable
|
run buildall |
TPC-H: Total hot run time: 31379 ms |
TPC-DS: Total hot run time: 172627 ms |
ClickBench: Total hot run time: 26.76 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)