VM Power state optimization

[nvazquez]

Description

This PR improves the publish VM power state loop and logs the graceful period

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[harikrishna-patnala]

code LGTM

[borisstoyanov]

@blueorangutan package

[blueorangutan]

@borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.23%. Comparing base (a4b1a27) to head (928033f).

Files with missing lines	Patch %	Lines
...com/cloud/vm/VirtualMachinePowerStateSyncImpl.java	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #12463   +/-   ##
=========================================
  Coverage     16.23%   16.23%           
- Complexity    13380    13382    +2     
=========================================
  Files          5657     5657           
  Lines        499035   499035           
  Branches      60567    60567           
=========================================
+ Hits          81029    81033    +4     
+ Misses       408969   408966    -3     
+ Partials       9037     9036    -1     

Flag	Coverage Δ
uitests	4.03% <ø> (ø)
unittests	17.09% <33.33%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16415

[DaanHoogland]

lgtm, but can you consider #12411, @nvazquez ? any change/optimisation to the power state loop might be linked to failures to sync as well…?