Change to display if public IPs are reserved in the tab #12461
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12461 +/- ##
============================================
+ Coverage 17.60% 17.85% +0.24%
- Complexity 15668 15982 +314
============================================
Files 5915 5929 +14
Lines 529967 531045 +1078
Branches 64734 64913 +179
============================================
+ Hits 93304 94794 +1490
+ Misses 426195 425636 -559
- Partials 10468 10615 +147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, it is possible to check whether a range of public IPs is reserved for system VMs or not; however, this information can be hard to find since it’s located in a sub-menu with a name that doesn’t relate to the topic. Thus, this PR moves this information directly to the ranges listing in the
Publictab under the Traffic types of a physical network.Types of changes
Feature/Enhancement Scale
Screenshots (if appropriate):
IP range before the changes:
IP range after the changes:
How Has This Been Tested?
I added two new IP ranges to a
Publictraffic type in a physical network, one being dedicated to system VMs, while the other was not. When the traffic type details was accessed, it was possible to validate that the dedicated range appeared astruein theReserved system IPcolumn, while the other one appeared asfalse.