refactor(@angular/cli): remove old package manager utilities #32279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: minor
alan-agius4
changed the title
This removes the old implementation of the package-manager.
alan-agius4
force-pushed
the
package-manager-old
branch
from
6de7103 to
3c4e6d5
Compare
alan-agius4
added
the
action: review
clydin
requested changes
Jan 20, 2026
| tempDirectory, | ||
| }); | ||
| task.output = `Using package manager: ${color.dim(context.packageManager.name)}`; | ||
| this.context.packageManager.temporaryDirectory = tempDirectory; |
Member
There was a problem hiding this comment.
Probably should move the temp directory discovery logic to the command runner as well so that other commands can take advantage of it too.
| * Gets the version of the package manager binary. | ||
| * @returns The version of the package manager binary. | ||
| */ | ||
| private getVersion(): string { |
Member
There was a problem hiding this comment.
I think we can use the async version throughout now. This also allows it to go through the host for debug logging.
| * @param globalWorkspace The global workspace. | ||
| * @returns The package manager name. | ||
| */ | ||
| async function getConfiguredPackageManager( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the old implementation of the package-manager.