Add SecretValue to string converter #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to return just a plain string due to the potential prefix, but thats misleaing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds conversion support from SecretValue to string. Secrets obtained through
core/get-secretcould already be plugged into a string, but only because that node already returned a string. Now that secrets can also be provided eg through agroup-inputthis bug became more apparent.actrun-cli/nodes/secret-get@v1.go
Line 40 in 5a849b1
With this change the
get-secretnode also returns a secret value object now (even with a potential prefix, just for simplicity and consistency).