NEW: Adding labels to make settings more readable

[josepmariapujol-unity]

Description

Adding labels to make settings more readable, values used in Action Properties: interactions and processors.

Result:

Values used here:

Testing status & QA

No need testing.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

• Complexity: 0
• Halo Effect: 0

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

• Changelog entry added.
  • Explains the change in Changed, Fixed, Added sections.
  • For API change contains an example snippet and/or migration example.
  • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
  • Jira port for the next release set as "Resolved".
• Tests added/changed, if applicable.
  • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
  • Performance tests.
  • Integration tests.
• Docs for new/changed API's.
  • Xmldoc cross references are set correctly.
  • Added explanation how the API works.
  • Usage code examples added.
  • The manual is updated, if needed.

During merge:

• Commit message for squash-merge is prefixed with one of the list:
  • NEW: ___.
  • FIX: ___.
  • DOCS: ___.
  • CHANGE: ___.
  • RELEASE: 1.1.0-preview.3.

[u-pr]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪ The change is limited to a couple of IMGUI layout calls and section headers in a single editor file.

🏅 Score: 92 The UI improvement is straightforward and low-risk, with only minor considerations around consistency/localization of editor strings.

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Localization The new section headers are hard-coded strings; consider using the project’s standard localization pattern for editor UI text (e.g., translated/GUIContent helpers) to keep consistency with other labels and enable localization. EditorGUILayout.LabelField("Action Properties - Processors", EditorStyles.boldLabel); EditorGUILayout.PropertyField(m_DefaultDeadzoneMin, m_DefaultDeadzoneMinContent); EditorGUILayout.PropertyField(m_DefaultDeadzoneMax, m_DefaultDeadzoneMaxContent); EditorGUILayout.Space(); EditorGUILayout.LabelField("Action Properties - Interactions", EditorStyles.boldLabel); EditorGUILayout.PropertyField(m_DefaultButtonPressPoint, m_DefaultButtonPressPointContent); Layout Consistency Added Space() calls may introduce extra vertical gaps compared to surrounding sections; verify the resulting spacing is consistent with other groups in this settings UI across editor themes and DPI scaling. EditorGUILayout.Space(); EditorGUILayout.LabelField("Action Properties - Interactions", EditorStyles.boldLabel); EditorGUILayout.PropertyField(m_DefaultButtonPressPoint, m_DefaultButtonPressPointContent); EditorGUILayout.PropertyField(m_ButtonReleaseThreshold, m_ButtonReleaseThresholdContent); EditorGUILayout.PropertyField(m_DefaultTapTime, m_DefaultTapTimeContent); EditorGUILayout.PropertyField(m_DefaultSlowTapTime, m_DefaultSlowTapTimeContent); EditorGUILayout.PropertyField(m_DefaultHoldTime, m_DefaultHoldTimeContent); EditorGUILayout.PropertyField(m_TapRadius, m_TapRadiusContent); EditorGUILayout.PropertyField(m_MultiTapDelayTime, m_MultiTapDelayTimeContent); EditorGUILayout.Space();

Update review

---

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

[u-pr]

PR Code Suggestions ✨

No code suggestions found for the PR.

[K-Tone]

Why is this change? Do we have a ticket of some sort? Also, do we want to update the changelog accordingly?

[codecov-github-com]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...putSystem/Editor/Settings/InputSettingsProvider.cs	0.00%	4 Missing ⚠️

@@             Coverage Diff             @@
##           develop    #2332      +/-   ##
===========================================
- Coverage    77.95%   77.94%   -0.01%     
===========================================
  Files          476      476              
  Lines        97453    97470      +17     
===========================================
+ Hits         75971    75976       +5     
- Misses       21482    21494      +12     

Flag	Coverage Δ
inputsystem_MacOS_2022.3	5.54% <0.00%> (+<0.01%)	⬆️
inputsystem_MacOS_2022.3_project	75.47% <0.00%> (+<0.01%)	⬆️
inputsystem_MacOS_6000.0	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.0_project	77.36% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.3	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.3_project	77.36% <0.00%> (+<0.01%)	⬆️
inputsystem_MacOS_6000.4	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.4_project	77.36% <0.00%> (+<0.01%)	⬆️
inputsystem_MacOS_6000.5	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.5_project	77.36% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_2022.3	5.54% <0.00%> (+<0.01%)	⬆️
inputsystem_Ubuntu_2022.3_project	75.27% <0.00%> (+<0.01%)	⬆️
inputsystem_Ubuntu_6000.0	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.0_project	77.16% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.3	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.3_project	77.16% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.4	5.33% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.4_project	77.17% <0.00%> (+<0.01%)	⬆️
inputsystem_Ubuntu_6000.5	5.33% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.5_project	77.17% <0.00%> (+<0.01%)	⬆️
inputsystem_Windows_2022.3	5.54% <0.00%> (+<0.01%)	⬆️
inputsystem_Windows_2022.3_project	75.60% <0.00%> (+<0.01%)	⬆️
inputsystem_Windows_6000.0	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.0_project	77.49% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.3	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.3_project	77.49% <0.00%> (+<0.01%)	⬆️
inputsystem_Windows_6000.4	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.4_project	77.49% <0.00%> (+<0.01%)	⬆️
inputsystem_Windows_6000.5	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.5_project	77.49% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...putSystem/Editor/Settings/InputSettingsProvider.cs	1.60% <0.00%> (+0.24%)	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[josepmariapujol-unity]

Why is this change? Do we have a ticket of some sort? Also, do we want to update the changelog accordingly?

I can make a ticket if needed. It is very strange to have all these values without some header section

[josepmariapujol-unity]

Or a new title such Default Action Property Values

[josepmariapujol-unity]

Do Button Release Threshold, Tap Radius and MultiTap Delay Time values relate to Action Properties?