-
Notifications
You must be signed in to change notification settings - Fork 330
FIX: Align title font size with toolbar style in Input Action window #2328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Align title font size with toolbar style in Input Action window #2328
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
PR Code Suggestions ✨No code suggestions found for the PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2328 +/- ##
===========================================
- Coverage 77.95% 77.95% -0.01%
===========================================
Files 476 476
Lines 97453 97466 +13
===========================================
+ Hits 75971 75976 +5
- Misses 21482 21490 +8 Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
...nity.inputsystem/InputSystem/Editor/UITKAssetEditor/PackageResources/InputActionsEditor.uxml
Outdated
Show resolved
Hide resolved
K-Tone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question regarding styles
| border-bottom-width: 1px; | ||
| height: 28px; | ||
| min-height: 28px; | ||
| font-size: 14px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, awesome, so we already had sizes defined in a css, just needed to change particular values. Thanks for doing this Josep!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, ideally, it would be better to hook these values to global editor variables to stay always in sync.
Description
This PR is addressing some of the UI issues that design team reported to input system.
Align title font size with toolbar style in Input Action window.
Before:

After:

JIRA: https://jira.unity3d.com/browse/ISX-2340
Testing status & QA
No testing is needed.
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.