Skip to content

NEW: Insights analytics support for the Input System #2272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
K-Tone wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

NEW: Insights analytics support for the Input System #2272

K-Tone wants to merge 9 commits into from

Conversation

@K-Tone
Copy link
Collaborator

@K-Tone K-Tone commented Oct 30, 2025 •
edited
Loading

Description

This PR brings support for the Insights analytics module to Input System.

Requires native side PR to land first: https://github.cds.internal.unity3d.com/unity/unity/pull/83832

Currently, we send these kinds of data to Insights:

  1. When a new input device is connected, we send this information:
  • product (" DUALSHOCK 4 Wireless Controller")
  • serial ("A0:5A:5E:92:0F:3E")
  • version ("1.0")
  • interface ("HID")
  1. When an input device is disconnected, we send this information:
  • serial (really intended to be matched with the event above at the time of analysis)
  1. When a new Input Action Map is being loaded or activated, we scan for all the Input Actions that are being brought to life and for each one, we send the following data:
  • name (e.g. "Jump")
  • type (e.g. "Button")

Testing status & QA

Local testing

Overall Product Risks

  • Complexity: Low
  • Halo Effect: Low

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@K-Tone K-Tone force-pushed the anthony/vector-analytics branch from 70a4618 to c93bcdb Compare January 16, 2026 10:26
@K-Tone K-Tone changed the title an example use case for the new vector analytics api Implement Insights analytics for device connect and disconnect events, and also for all Input Actions that are spawned from Input Action Maps Jan 20, 2026
@K-Tone K-Tone changed the title Implement Insights analytics for device connect and disconnect events, and also for all Input Actions that are spawned from Input Action Maps Insights analytics support for the Input System Jan 20, 2026
ekcoh
ekcoh reviewed Jan 20, 2026
View reviewed changes
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but would suggest to use interface similar to other module facing calls given the current test fixture design.

K-Tone
K-Tone commented Jan 20, 2026
View reviewed changes
Packages/com.unity.inputsystem/InputSystem/Unity.InputSystem.asmdef
},
{
"name": "Unity",
"expression": "6000.5.0a5",
Copy link
Collaborator Author

@K-Tone K-Tone Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have to be changed to whatever is the actual Unity version we happen to release Input insights in. We will know that once the native PR lands. Then we will change this for every backport

ekcoh
ekcoh approved these changes Jan 21, 2026
View reviewed changes
Packages/com.unity.inputsystem/Tests/TestFixture/InputTestRuntime.cs

#endif // UNITY_ANALYTICS || UNITY_EDITOR
// We don't want to populate Insights from within tests, even when running them in players
public void LogDeviceConnectedInsight(InputDeviceDescription description)
Copy link
Collaborator

@ekcoh ekcoh Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to store these in harness in case you want to test it in the package

@ekcoh ekcoh changed the title Insights analytics support for the Input System NEW: Insights analytics support for the Input System Jan 21, 2026
@ekcoh
Copy link
Collaborator

ekcoh commented Jan 21, 2026

Looks like you need to (re)run formatter on this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekcoh ekcoh ekcoh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@K-Tone @ekcoh