Propagate PhysicalBridge backlog to ServerCounters #2996
+73
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SeverCounters.TotalOutstandingwas not including messages in thePhysicalBridgebacklog queue. ThePendingUnsentItemsproperty was never being set, so it always returned 0.This caused a significant issue when using
TotalOutstandingfor connection load balancing in our PROD runtime: a connection that was stuck or slow (with messages accumulating in the backlog) would still reportTotalOutstanding ≈ 0, making it appear healthy and causing more traffic to be preferentially routed to the unhealthy connection.Fix
Propagate the
_backlogCurrentEnqueuedin theConnectionCountersreturned byPhysicalBridgeso that the number of messages in backlog queue can be exposed to end user