WWSTCERT-9109 Added support for Bosch matter motion sensor #2555
+54
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 71 files 480 suites 0s ⏱️ For more details on these failures, see this check. Results for commit a7599b5. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against a7599b5 |
greens
changed the title
hcarter-775
reviewed
Nov 25, 2025
| @@ -0,0 +1,29 @@ | |||
| name: light-level-motion-illuminance-battery-temp | |||
Contributor
There was a problem hiding this comment.
Would you mind changing the name and file to light-level-battery-illuminance-motion-temperature to more closely fit the naming convention already created. Thanks!
Contributor
There was a problem hiding this comment.
also, please move battery, firmwareUpdate and refresh to the bottom, below switchLevel. battery should be above the other two. Thanks!
hcarter-775
reviewed
Nov 25, 2025
Comment on lines
195
to
198
| updated_profile = "light-level-motion" | ||
| if switch_utils.check_switch_category_vendor_overrides(device) then | ||
| updated_profile = fields.vendor_overrides[device.manufacturer_info.vendor_id][device.manufacturer_info.product_id].target_profile | ||
| end |
Contributor
There was a problem hiding this comment.
Suggested change
| updated_profile = "light-level-motion" | |
| if switch_utils.check_switch_category_vendor_overrides(device) then | |
| updated_profile = fields.vendor_overrides[device.manufacturer_info.vendor_id][device.manufacturer_info.product_id].target_profile | |
| end | |
| updated_profile = switch_utils.get_product_override_field(device, "target_profile") or "light-level-motion" |
the check_switch_category_vendor_overrides function is unrelated to this logic.
Contributor
|
Has this been tested on-device? |
JanJakubiszyn
force-pushed
the
Bosch_motion_sensor_support
branch
from
f1676a1 to
0723d13
Compare
Contributor
Author
Yes, I have tested it with the device and it works well. I have implemented all of the mentioned changes from the review. Thank You! |
Contributor
|
@JanJakubiszyn You'll need to rebase your changes. |
JanJakubiszyn
force-pushed
the
Bosch_motion_sensor_support
branch
from
6ca7abe to
23045f1
Compare
Contributor
Author
All done. |
hcarter-775
approved these changes
Dec 8, 2025
JanJakubiszyn
force-pushed
the
Bosch_motion_sensor_support
branch
from
0b18bd6 to
98408c7
Compare
Contributor
Author
|
Hi @hcarter-775, @greens,
Please let me know if I should proceed with editing the rest of the unit tests accordingly or should I take a different approach. |
Contributor
|
Looks like this has fallen out of date again |
# Conflicts: # drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua # drivers/SmartThings/matter-switch/src/switch_utils/fields.lua
… name and capability order, edit of the match_profile's condition # Conflicts: # drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua
…nged and setting default dimmer value of the device to 100% after on command is triggered
JanJakubiszyn
force-pushed
the
Bosch_motion_sensor_support
branch
from
352509c to
a7599b5
Compare
Contributor
|
Your changes seem to have led to tests failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests